Page MenuHomeWildfire Games

[WIP] Ambient emitters
Needs ReviewPublic

Authored by Stan on Nov 2 2019, 6:24 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Trac Tickets
#1962
Summary

See #1962 and P41. (Original patch by Sandarac)

TODO:

All the todos.

Test Plan

Test that ambient sounds work

Event Timeline

Stan created this revision.Nov 2 2019, 6:24 PM
Vulcan added a comment.Nov 2 2019, 6:25 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1027/display/redirect

Vulcan added a comment.Nov 2 2019, 6:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/512/display/redirect

Stan updated this revision to Diff 10674.Dec 20 2019, 6:40 PM

Fix const reference

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1331/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/815/display/redirect

Stan updated this revision to Diff 10675.Dec 20 2019, 7:17 PM

Another attemp

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1332/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/816/display/redirect

Stan updated this revision to Diff 10676.Dec 20 2019, 7:40 PM

Try with temp variables

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1333/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/817/display/redirect

Stan updated this revision to Diff 10677.Dec 20 2019, 7:42 PM

Fix shadowing, early return

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1334/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/818/display/redirect

Stan updated this revision to Diff 10678.Dec 20 2019, 7:53 PM

Add const

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/819/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/ICmpSoundManager.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/simulation2/components/ICmpSoundManager.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/simulation2/components/ICmpSoundManager.h
|  28| class·ICmpSoundManager·:·public·IComponent
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classICmpSoundManager:' is invalid C code. Use --std or --language to configure the language.

source/soundmanager/SoundManager.h
|  27| #include·"items/ISoundItem.h"
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classISoundManager{' is invalid C code. Use --std or --language to configure the language.

source/soundmanager/ISoundManager.h
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"

source/soundmanager/ISoundManager.h
|  27| class·ISoundManager
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classISoundManager{' is invalid C code. Use --std or --language to configure the language.

source/simulation2/components/CCmpSoundManager.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2018"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1335/display/redirect

Stan updated this revision to Diff 10682.Dec 20 2019, 11:22 PM

Working version... Still weird quirks in Atlas. Needs some cleanup.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1336/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/820/display/redirect

Freagarach added inline comments.
binaries/data/mods/public/simulation/components/Sound.js
65

Perhaps we can use a timer?

@Stan polite ping, any update on this?

Stan added a comment.Aug 28 2020, 11:50 PM

Not currently.

Stan updated this revision to Diff 13623.Mon, Oct 12, 7:57 PM

Quick rebase

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-macos.txt
In file included from ../../../source/soundmanager/SoundManager.cpp:21:
In file included from ../../../source/soundmanager/SoundManager.h:28:
../../../source/soundmanager/scripting/SoundGroup.h:63:27: error: extra qualification on member 'GetRandomSound'
        CSoundData* CSoundGroup::GetRandomSound();
                    ~~~~~~~~~~~~~^
In file included from ../../../source/ps/scripting/JSInterface_Game.cpp:32:
In file included from ../../../source/soundmanager/SoundManager.h:28:
../../../source/soundmanager/scripting/SoundGroup.h:63:27: error: extra qualification on member 'GetRandomSound'
        CSoundData* CSoundGroup::GetRandomSound();
                    ~~~~~~~~~~~~~^
1 error generated.
make[1]: *** [obj/engine_Debug/JSInterface_Game.o] Error 1
make[1]: *** Waiting for unfinished jobs....
1 error generated.
make[1]: *** [obj/engine_Debug/SoundManager.o] Error 1
make: *** [engine] Error 2

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1643/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
In file included from ../../../source/soundmanager/SoundManager.h:28:0,
                 from ../../../source/ps/scripting/JSInterface_Game.cpp:32:
../../../source/soundmanager/scripting/SoundGroup.h:63:14: error: extra qualification 'CSoundGroup::' on member 'GetRandomSound' [-fpermissive]
  CSoundData* CSoundGroup::GetRandomSound();
              ^~~~~~~~~~~
make[1]: *** [obj/engine_Debug/JSInterface_Game.o] Error 1
make: *** [engine] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3295/display/redirect