@Stan do you want this to be committed for A26 or A27 ?

any update?

any update on this?

I believe this is a nice change I agree with, please correct the inlines which others mentioned.

I already voted on the forum for the version with the image on the right.

I also believe this patch goes in the right direction and could be committed so it could be tried in the next RC release.

I am ok with this.

Many thanks for working on this and yeah screen size responsive layouts are considered, recently in alpha 26 there is GUI setting now available inside a game that was previously in user.cfg where it would have to be written manually but @marder said that he would need full CSS support for it.

Will there be an update on this, since it was committed for a minimap?

Is this something we want also for the engine? Well maybe for campaigns and cinematics but we have smth similar in Atlas.

@wraitii @vladislavbelov I believe you two can review this.

In D4659#198150, @Langbart wrote:

:) no matches found for Han Chinese, only the single word Chinese still shows up in some files e.g. Chinese Fire Ship Alight , should it be called Chinese ... or Han ... / Han Dynasty ... ?

❯ rg '(Han)*Chinese' -g='!l10n' -g='!translators.json' --stats
mods/public/simulation/templates/units/han/champion_chariot.xml
9:    <GenericName>Chinese War Chariot</GenericName>

mods/public/simulation/templates/special/players/han.xml
18:    <History>The Han dynasty (206 BC – AD 220) was the second imperial dynasty of China, preceded by the Qin dynasty (221–207 BC) and succeeded by the Three Kingdoms period (AD 220–280). It is considered a golden age in Chinese history, and China made significant progress in arts and sciences during the Han period. The core of the Han empire was around the Wei River, and the Han capital was Chang'an, very close to the Qin capital Xianyang (both are now part of Xi'an, Shaanxi).</History>

mods/public/simulation/data/technologies/crossbow_training.json
3:	"description": "The Chinese had a tradition of fine archery and a penchant for using massed crossbowmen in battle.",

mods/public/simulation/data/technologies/art_of_war.json
4:	"description": "This famous and most important work of the Seven Military Classics teaches Chinese commanders everything about planning battles, maintaining armies, and defeating one's enemies.",

mods/public/art/actors/structures/han/fishing_ship.xml
6:    <variant name="Chinese Fishing Ship">

mods/public/art/actors/structures/han/fireship_fire.xml
6:    <variant name="Chinese Fire Ship Alight">

mods/public/art/actors/structures/han/fireship.xml
6:    <variant name="Chinese Fire Ship">

mods/public/art/actors/structures/han/merchant_ship.xml
6:    <variant name="Chinese Merchant Ship">

mods/public/art/actors/structures/han/towership.xml
6:    <variant name="Chinese Towership">

mods/public/art/actors/structures/han/bireme.xml
6:    <variant name="Chinese Bireme">

mods/public/art/actors/structures/han/trireme.xml
6:    <variant name="Chinese Trireme">

mods/public/art/actors/props/structures/han/civic_center_leaves.xml
5:    <variant frequency="1" name="Chinese CC leaves">

mods/public/art/actors/props/structures/han/range_nature.xml
5:    <variant frequency="1" name="Chinese range nature">

mods/public/art/actors/props/structures/han/bixie_nature.xml
5:    <variant frequency="1" name="Chinese bixie nature">

mods/public/art/actors/props/structures/han/civic_center_nature.xml
5:    <variant frequency="1" name="Chinese CC plants">

mods/public/art/actors/props/structures/han/civic_center_bixie_gold.xml
5:    <variant frequency="1" name="Golden Chinese CC Bixie statues">

mods/public/art/actors/props/structures/han/civic_center_trunks.xml
5:    <variant frequency="1" name="Chinese CC trunks">

mods/public/art/actors/props/structures/han/civic_center_bixie.xml
5:    <variant frequency="1" name="Chinese CC Bixie statues">

mods/public/art/actors/props/structures/han/ministry_bixie.xml
5:    <variant frequency="1" name="Chinese CC Bixie statues">

mods/public/art/actors/props/structures/han/bixie.xml
5:    <variant frequency="1" name="Chinese Bixie">

mods/public/art/actors/props/structures/han/wonder_nature.xml
5:    <variant frequency="1" name="Chinese wonder nature">

21 matches
21 matched lines
21 files contained matches
26225 files searched
3008 bytes printed
1917303123 bytes searched
84.324502 seconds spent searching
10.780179 seconds

Langbart found some other not fixed matches, please fix those too. Thanks @Langbart

I agree, did you try to use grep?

It does make sense to me too.

It could be considered a bugfix which ads GUI part too but that depends if @Stan @Silier @Freagarach agree that it can be committed.

In D4621#196549, @Stan wrote:

Patch by: @elexis
Authored by: @Langbart

In D4621#196517, @Stan wrote:

Who should we credit here?

In D4619#196402, @Silier wrote:

Agree siege shouldn't probably be affected especially rams, but non soldiers shouldn't be excluded.

That said, resources that means not alive entities should be excluded from aura.

I second that. (also agree)

I agree with this one

I think this is a nice improvement to continue to work on this but it would be nice if we ask @vladislavbelov if the bad ARB cases could be improved or limited.

I believe this should go into A26 for debugging purposes.

accepted by @asterix

accepted by @asterix

I agree.

Since feature freeze is on Sunday this week, I do not see it as realistic to see it included in A26, unfortunately.

@marder @Stan could you look at it again?

In D4189#192764, @Stan wrote:

Would give more time for translators, though.

It would be nice if it can get before feature freeze A26.

I agree. @marder @Freagarach @wowgetoffyourcellphone can you test this as well?

In rP26462#56225, @Lionkanzen wrote:

Why are you going to delete the princess tent?

the problems and possible solutions are discussed here. https://wildfiregames.com/forum/topic/71578-feedbacks-from-a26-svn-tests/#comment-480686

@Stan can this be committed?

@bb it would be nice if you could review this

In D4291#191252, @marder wrote:

@asterix thanks :) but I think first there needs to be a discussion if this feature is good as it is, if there should be any changes or if this just adds too much complexity for too little gain gameplay-wise.
But you are very welcome to try it out and report how it feels!

it will be nice if it could be committed in A26 since Han civ is going to be committed.

@Freagarach will you continue working on this?

needs rebase

I am not against it.

@Silier can you look at this?

I agree, I know it is only for debugging but I am getting real wololo vibes.

Yes, I agree, my main concern is that they would be able to change this message in real-time since they were able to do DDoS attacks.

@wraitii perhaps you can look at it again.

It would be nice if it can be committed. @Freagarach

cannot it be committed?

if this gets committed @Stan could you make another testing bundle as you did for Christmas?

I agree with the behavior.

@wowgetoffyourcellphone

@Freagarach will you commit this?

In D4438#189832, @Freagarach wrote:

(I'll aim to commit this this week unless objected.)

I like this idea too, hopefully we can get fattening like in aoe3.

you can also ask users/players on forums for more feedback and testing

In D4444#189779, @Langbart wrote:

In D4444#189777, @asterix wrote:

@Langbart @Freagarach can you test this?

its wip

@Langbart @Freagarach can you test this?

Is this still necessary since this https://code.wildfiregames.com/D4428 is in development?

any eta on this?

I believe this is still useful

any update on this?

since hyrule conquest is going full node based mode I believe this will be a very desired feature

this will be nice to add

unit pushing is in vanilla so this will be reworked?

any update on this?

Accepting Revision for functionality.

I believe @Freagarach also should test this since I believe he has very old computer.

@Silier two comments above from @Stan

I confirm that it works on my notebook HP Pavilion with Nvidea Geforce 960m and intel integrated graphics Intel® HD Graphics 530
processor Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz 2.59 GHz RAM 8GB

anything still this patch needs to be committed?

any decision here @Stan @Freagarach, since freetype was added other types of fonts, glyphs, alphabets are possible but I believe we still lack rendering of them eg. asian languages?

what is needed for this patch being committed @Stan @Freagarach ?

description seems correct to me