Differential D256
clean-workspaces.sh should delete all cpp testfiles Authored by elexis on Mar 24 2017, 12:01 AM.
Details One can't move the svn checkout directory and then do a clean compile there, because the dynamically generated cpp test files still contain the old path and Functions with the given names in that file are needed since they are referenced by the functions tested in these files. Apply the patch to a working copy that had succeeded a compile previously.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/583/ for more details. Comment Actions I'm not really happy with that rename, especially as that file doesn't contain an actual test. (Yes, it is picked up by the test file generation due to being a .h file in a test/ directory, but well.) Better than this would be explicitly deleting that file, or rewriting that find rule to look for test/ directories and delete all .cpp files therein. Even better would be fixing the generated makefiles in a way that make clean actually deletes all the files it generates. Comment Actions At least it would allow moving the directory and compiling again.
Can't move it to test_root.cpp, because that file is generated. ./gui/tests/test_ParseString.h ./lib/res/graphics/tests/test_tex.h ./lib/file/disabled_tests/test_file_cache.h ./lib/file/disabled_tests/test_path.h ./lib/file/common/tests/test_trace.h ./lib/file/vfs/tests/test_vfs_tree.h ./lib/file/archive/disabled_tests/test_fat_time.h ./lib/file/archive/disabled_tests/test_codec_zlib.h ./lib/file/archive/disabled_tests/test_zip.h ./lib/file/archive/disabled_tests/test_compression.h ./lib/tests/test_bits.h ./lib/tests/test_wchar.h ./lib/tests/test_path_util.h ./lib/tests/test_adts.h ./lib/tests/test_byte_order.h ./lib/tests/test_cache_adt.h ./lib/tests/test_fnv_hash.h ./lib/tests/test_secure_crt.h ./lib/tests/test_rand.h ./lib/tests/test_base32.h ./lib/tests/test_path.h ./lib/tests/test_regex.h ./lib/tests/test_lib.h ./lib/sysdep/os/win/tests/test_wdbg_sym.h ./lib/sysdep/os/win/tests/test_ia32.h ./lib/sysdep/tests/test_rtl.h ./lib/sysdep/tests/test_sysdep.h ./lib/sysdep/arch/x86_x64/tests/test_topology.h ./lib/allocators/tests/test_allocators.h ./lib/allocators/tests/test_headerless.h ./lib/posix/tests/test_posix.h ./simulation2/tests/test_ComponentManager.h ./simulation2/tests/test_Simulation2.h ./simulation2/tests/test_Serializer.h ./simulation2/tests/test_ParamNode.h ./simulation2/tests/test_CmpTemplateManager.h ./simulation2/components/tests/test_Position.h ./simulation2/components/tests/test_CommandQueue.h ./simulation2/components/tests/test_TerritoryManager.h ./simulation2/components/tests/test_ObstructionManager.h ./simulation2/components/tests/test_RangeManager.h ./simulation2/components/tests/test_scripts.h ./simulation2/components/tests/test_Pathfinder.h ./scriptinterface/tests/test_ObjectToIDMap.h ./scriptinterface/tests/test_ScriptConversions.h ./scriptinterface/tests/test_ScriptInterface.h ./network/tests/test_Net.h ./network/tests/test_NetMessage.h ./maths/tests/test_FixedVector3D.h ./maths/tests/test_Bound.h ./maths/tests/test_Fixed.h ./maths/tests/test_Sqrt.h ./maths/tests/test_FixedVector2D.h ./maths/tests/test_Matrix3d.h ./maths/tests/test_Random.h ./maths/tests/test_MD5.h ./maths/tests/test_Brush.h ./tools/atlas/AtlasObject/tests/test_AtlasObjectXML.h ./ps/XML/tests/test_Xeromyces.h ./ps/XML/tests/test_XeroXMB.h ./ps/XML/tests/test_XMLWriter.h ./ps/XML/tests/test_RelaxNG.h ./ps/GameSetup/tests/test_CmdLineArgs.h ./ps/tests/test_test.h ./ps/tests/test_CColor.h ./ps/tests/test_CLogger.h ./ps/tests/test_Preprocessor.h ./ps/tests/test_cppformat.h ./ps/tests/test_CStr.h ./third_party/encryption/tests/test_pkcs5_pbkdf5.h ./third_party/encryption/tests/test_sha.h ./graphics/tests/test_TextureManager.h ./graphics/tests/test_Color.h ./graphics/tests/test_ShaderManager.h ./graphics/tests/test_LOSTexture.h ./graphics/tests/test_TextureConverter.h ./graphics/tests/test_Terrain.h ./graphics/tests/test_MeshManager.h
Sounds managable in less than a handful of hours.
Doesn't sound managable in less than a handful of hours if one isn't familiar with that. Patches welcome. Comment Actions As mentioned above I'd prefer a nice fix that would make make clean work, but I'd also be happy with an improved find/rm combination. Comment Actions Would be nice to be able to move the 0AD folder without having to delete that file manually. Comment Actions
Yes, would be nice, but it is still an uncommon use case and those running into it might want to consider this a simple ticket, or open one.
Just because someone might be able to fix all simple tickets we have by investing a weekend doesn't mean they have to. |