Verify that nothing breaks.
Details
Details
- Reviewers
Silier - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23563: Explicitly return "undefined" when requesting Splash data in Attack.js
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 11304 Build 20393: Vulcan Build Jenkins Build 20392: Vulcan Build (macOS) Jenkins Build 20391: Vulcan Build (Windows) Jenkins Build 20390: arc lint + arc unit
Event Timeline
Comment Actions
Build was aborted.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1891/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1897/display/redirect
Comment Actions
Compared to other occurrences in code base, it makes sense to return undefined rather then just empty return.
According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions, return value of empty return is undefined so there is no problem with this change in code and logic level.