Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23697: Add slaughter animations to most units.
Check for completeness
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2028/display/redirect
Comment Actions
You are probably the only one around who is able to review that. I am not aware of your current policy but commiting that wouldn't appear as a frenzy.
I had wondered something.
Just quickly looking at other templates in a no brain way, it appears that some specific variants are used.
Here a (still no brain) list of the file available:
There are some other variants:
./attack_slaughter.xml ./cape_attack_slaughter.xml ./rider/attack_slaughter_hele.xml ./rider/attack_slaughter_iber.xml ./rider/attack_slaughter_kush.xml ./rider/attack_slaughter_pers.xml ./rider/attack_slaughter_shield_cart.xml ./rider/attack_slaughter_shield_celt.xml ./rider/attack_slaughter_shield_hele.xml ./rider/attack_slaughter_shield_iber.xml ./rider/attack_slaughter_shield_kush.xml ./rider/attack_slaughter_shield_maur.xml ./rider/attack_slaughter_shield_pers.xml ./rider/attack_slaughter_shield_rome.xml ./rider/attack_slaughter_shield_spart.xml ./rider/attack_slaughter_shield.xml ./rider/attack_slaughter_spart.xml ./rider/attack_slaughter.xml ./rider/camelry/attack_slaughter_kush.xml ./rider/camelry/attack_slaughter_ptol.xml ./rider/camelry/attack_slaughter.xml ./rider/cape_attack_slaughter_shield.xml ./rider/cape_attack_slaughter.xml
And the files where they are used (I didn't list the normal biped/attack_slaughter):
units/ptolemies/camelry_archer_b_r.xml 24: <variant file="biped/rider/camelry/attack_slaughter_ptol.xml"/> units/ptolemies/camelry_archer_e_r.xml 24: <variant file="biped/rider/camelry/attack_slaughter_ptol.xml"/> units/ptolemies/cavalry_spearman_b_r.xml 34: <variant file="biped/rider/attack_slaughter_hele.xml"/> units/ptolemies/camelry_archer_a_r.xml 24: <variant file="biped/rider/camelry/attack_slaughter_ptol.xml"/> units/ptolemies/cavalry_spearman_a_r.xml 41: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/ptolemies/cavalry_spearman_e_r.xml 62: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/britons/cavalry_javelinist_e_r.xml 93: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/britons/cavalry_javelinist_a_r.xml 105: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/britons/cavalry_swordsman_b_r.xml 64: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/britons/cavalry_swordsman_a_r.xml 99: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/britons/cavalry_javelinist_b_r.xml 85: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/britons/cavalry_swordsman_e_r.xml 74: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/macedonians/cavalry_javelinist_e_r.xml 102: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/macedonians/cavalry_javelinist_a_r.xml 36: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/macedonians/cavalry_spearman_b_r.xml 23: <variant file="biped/rider/attack_slaughter_hele.xml"/> units/macedonians/cavalry_javelinist_b_r.xml 38: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/macedonians/cavalry_spearman_a_r.xml 23: <variant file="biped/rider/attack_slaughter_hele.xml"/> units/macedonians/cavalry_spearman_e_r.xml 55: <variant file="biped/rider/attack_slaughter_hele.xml"/> units/carthaginians/cavalry_javelinist_e_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_cart.xml"/> units/carthaginians/cavalry_javelinist_a_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_cart.xml"/> units/carthaginians/cavalry_spearman_b_r.xml 69: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/carthaginians/cavalry_javelinist_b_r.xml 33: <variant file="biped/rider/attack_slaughter_shield_cart.xml"/> units/carthaginians/cavalry_spearman_a_r.xml 73: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/carthaginians/cavalry_spearman_e_r.xml 71: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/mauryas/cavalry_javelinist_e_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_maur.xml"/> units/mauryas/cavalry_javelinist_a_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_maur.xml"/> units/mauryas/cavalry_swordsman_b_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_maur.xml"/> units/mauryas/cavalry_swordsman_a_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_maur.xml"/> units/mauryas/cavalry_javelinist_b_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_maur.xml"/> units/mauryas/cavalry_swordsman_e_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_maur.xml"/> units/persians/cavalry_javelinist_e_r.xml 41: <variant file="biped/rider/attack_slaughter_shield_pers.xml"/> units/persians/cavalry_javelinist_a_r.xml 40: <variant file="biped/rider/attack_slaughter_shield_pers.xml"/> units/persians/cavalry_archer_a_r.xml 36: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/persians/cavalry_swordsman_b_r.xml 23: <variant file="biped/rider/attack_slaughter_pers.xml"/> units/persians/cavalry_archer_e_r.xml 27: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/persians/cavalry_swordsman_a_r.xml 35: <variant file="biped/rider/attack_slaughter_shield_pers.xml"/> units/persians/cavalry_spearman_b_r.xml 39: <variant file="biped/rider/attack_slaughter_pers.xml"/> units/persians/cavalry_javelinist_b_r.xml 82: <variant file="biped/rider/attack_slaughter_shield_pers.xml"/> units/persians/cavalry_spearman_a_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_pers.xml"/> units/persians/cavalry_spearman_e_r.xml 78: <variant file="biped/rider/attack_slaughter_pers.xml"/> units/persians/cavalry_archer_b_r.xml 25: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/persians/cavalry_swordsman_e_r.xml 26: <variant file="biped/rider/attack_slaughter_shield_pers.xml"/> units/kushites/cavalry_javelinist_e_r.xml 64: <variant file="biped/rider/attack_slaughter_shield_kush.xml"/> units/kushites/cavalry_javelinist_a_r.xml 69: <variant file="biped/rider/attack_slaughter_shield_kush.xml"/> units/kushites/cavalry_spearman_b_r.xml 67: <variant file="biped/rider/attack_slaughter_kush.xml"/> units/kushites/camelry_javelinist_b_r.xml 35: <variant file="biped/rider/camelry/attack_slaughter_kush.xml"/> units/kushites/cavalry_javelinist_b_r.xml 72: <variant file="biped/rider/attack_slaughter_shield_kush.xml"/> units/kushites/cavalry_spearman_a_r.xml 68: <variant file="biped/rider/attack_slaughter_shield_kush.xml"/> units/kushites/cavalry_spearman_e_r.xml 63: <variant file="biped/rider/attack_slaughter_shield_kush.xml"/> units/gauls/cavalry_javelinist_e_r.xml 103: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/gauls/cavalry_javelinist_a_r.xml 95: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/gauls/cavalry_swordsman_b_r.xml 64: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/gauls/cavalry_swordsman_a_r.xml 116: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/gauls/cavalry_javelinist_b_r.xml 75: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/gauls/cavalry_swordsman_e_r.xml 94: <variant file="biped/rider/attack_slaughter_shield_celt.xml"/> units/iberians/cavalry_javelinist_e_r.xml 65: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/iberians/cavalry_javelinist_c_r.xml 60: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/iberians/cavalry_javelinist_a_r.xml 51: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/iberians/cavalry_swordsman_b_r.xml 48: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/iberians/cavalry_swordsman_a_r.xml 39: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/iberians/cavalry_spearman_b_r.xml 47: <variant file="biped/rider/attack_slaughter_iber.xml"/> units/iberians/cavalry_javelinist_b_r.xml 33: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/iberians/cavalry_spearman_a_r.xml 37: <variant file="biped/rider/attack_slaughter_iber.xml"/> units/iberians/cavalry_spearman_e_r.xml 65: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/iberians/cavalry_swordsman_e_r.xml 75: <variant file="biped/rider/attack_slaughter_shield_iber.xml"/> units/spartans/cavalry_javelinist_e_r.xml 37: <variant file="biped/rider/attack_slaughter_shield_spart.xml"/> units/spartans/cavalry_javelinist_a_r.xml 26: <variant file="biped/rider/attack_slaughter_shield_spart.xml"/> units/spartans/cavalry_spearman_b_r.xml 23: <variant file="biped/rider/attack_slaughter_spart.xml"/> units/spartans/cavalry_javelinist_b_r.xml 26: <variant file="biped/rider/attack_slaughter_shield_spart.xml"/> units/spartans/cavalry_spearman_a_r.xml 24: <variant file="biped/rider/attack_slaughter_spart.xml"/> units/spartans/cavalry_spearman_e_r.xml 75: <variant file="biped/rider/attack_slaughter_spart.xml"/> units/romans/cavalry_javelinist_e_r.xml 164: <variant file="biped/rider/attack_slaughter_shield_rome.xml"/> units/romans/cavalry_javelinist_a_r.xml 80: <variant file="biped/rider/attack_slaughter_shield_rome.xml"/> units/romans/cavalry_spearman_b_r.xml 26: <variant file="biped/rider/attack_slaughter_shield_rome.xml"/> units/romans/cavalry_javelinist_b_r.xml 77: <variant file="biped/rider/attack_slaughter_shield_rome.xml"/> units/romans/cavalry_spearman_a_r.xml 73: <variant file="biped/rider/attack_slaughter_shield_rome.xml"/> units/romans/cavalry_spearman_e_r.xml 55: <variant file="biped/rider/attack_slaughter_shield_rome.xml"/> units/athenians/cavalry_javelinist_e_r.xml 54: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/athenians/cavalry_javelinist_a_r.xml 50: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/athenians/cavalry_swordsman_b_r.xml 38: <variant file="biped/rider/attack_slaughter_hele.xml"/> units/athenians/cavalry_swordsman_a_r.xml 41: <variant file="biped/rider/attack_slaughter_hele.xml"/> units/athenians/cavalry_javelinist_b_r.xml 26: <variant file="biped/rider/attack_slaughter_shield_hele.xml"/> units/athenians/cavalry_swordsman_e_r.xml 155: <variant file="biped/rider/attack_slaughter_hele.xml"/>
Comment Actions
Yeah. I wish I could duplicate myself like this. Must be very convenient. So I'm not sure, did the other fatherbushido imply that the patch was complete?