Page MenuHomeWildfire Games

Fix a few mistakes in the lobby readme.
ClosedPublic

Authored by leper on Dec 30 2016, 8:35 PM.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
upstream
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 77
Build 129: Vulcan BuildJenkins
Build 128: arc lint + arc unit

Event Timeline

leper updated this revision to Diff 90.Dec 30 2016, 8:35 PM
leper retitled this revision from to Fix a few mistakes in the lobby readme..
leper updated this object.
leper edited the test plan for this revision. (Show Details)
leper added a reviewer: scythetwirler.
scythetwirler edited edge metadata.Dec 30 2016, 9:17 PM

Looks good to me.

scythetwirler accepted this revision.Dec 30 2016, 9:18 PM
scythetwirler edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2016, 9:18 PM
Vulcan added a subscriber: Vulcan.Dec 30 2016, 11:17 PM

Build is green

Updating workspaces.
Build (release)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
 void CChart::HandleMessage(SGUIMessage& Message)
                                         ^
../../../source/lib/tex/tex_png.cpp: In member function ‘virtual Status TexCodecPng::encode(Tex*, DynArray*) const’:
../../../source/lib/tex/tex_png.cpp:309:9: warning: variable ‘ret’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Wclobbered]
  Status ret = ERR::FAIL;
         ^
Build (debug)...
../../../source/gui/CChart.cpp:38:41: warning: unused parameter ‘Message’ [-Wunused-parameter]
 void CChart::HandleMessage(SGUIMessage& Message)
                                         ^
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/61/ for more details.

This revision was automatically updated to reflect the committed changes.
elexis added a subscriber: elexis.Dec 31 2016, 10:54 AM

(Didn't we intend to attempt to avoid or complete TODOs before committing? Also it is nice to have reviewers mentioned in the commit message)

(Probably, but I asked someone to add what this TODO refers to quite some time ago and the result was that I can still add this now. Also I'm not going to fix this, so well. Not sure having the reviewers listed for this commit is useful; might be nice to have just reviewed by and differential revision added to the commit message.)

elexis changed the visibility from "All Users" to "Public (No Login Required)".Jun 26 2017, 2:23 PM