Page MenuHomeWildfire Games
Differential D2906

Add more animations to the atlas drop-down list and delete non-existent animations
ClosedPublic
Actions

Authored by Mr.lie on Jul 25 2020, 3:12 PM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23904: Add more animations to the atlas drop-down list and delete non-existent…
Summary

This patch completed and correct the drop-down list in atlas editor for providing the opportunity to play most of the given animations:

  • add the approach_* animations
  • complete the gather_* and carry_* animations
  • delete most of the non-existent formations-animation and add the correct animations
Test Plan

In atlas iterate thru all unit-actors and all animations to see that every animation is present works.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mr.lie created this revision.Jul 25 2020, 3:12 PM
Stan added subscribers: wraitii, Stan.Jul 25 2020, 3:43 PM
Stan added inline comments.
binaries/data/tools/atlas/lists.xml
33 ↗(On Diff #12919)

Refs D1337 / rP22442 cc: @wraitii

85 ↗(On Diff #12919)

Refs D1337 / rP22442

Stan accepted this revision.Jul 25 2020, 4:00 PM
Stan added a subscriber: trompetin17.

Looks good! @trompetin17 @wraitii would be nice to be able to combine animations such as Walk + Testudo...

This revision is now accepted and ready to land.Jul 25 2020, 4:00 PM
Mr.lie added a comment.EditedJul 26 2020, 2:58 AM
In D2906#125954, @Stan wrote:

Looks good! @trompetin17 @wraitii would be nice to be able to combine animations such as Walk + Testudo...

Have a look at https://youtu.be/VvPVGYmT7LU

Stan added a comment.Jul 26 2020, 5:52 PM

But you removed them above ^

Mr.lie added a comment.Jul 26 2020, 10:39 PM
In D2906#126052, @Stan wrote:

But you removed them above ^

Yes, because they were deleted in 22442. For experimenting i've added this animations to the "base_swordsman_shield_relax_rome.xml" and named they as "walk_testudo_*". After that the animations will be played in atlas.

Stan added a comment.Jul 26 2020, 11:01 PM

I see. Then my point above stand. We should have a way to combine walk + anim

Closed by commit rP23904: Add more animations to the atlas drop-down list and delete non-existent… (authored by Stan). · Explain WhyJul 27 2020, 9:36 AM
This revision was automatically updated to reflect the committed changes.
Stan added a commit: rP23904: Add more animations to the atlas drop-down list and delete non-existent….

Revision Contents
Changeset List

PathSize
ps/
trunk/
binaries/
data/
tools/
atlas/
58 lines

Diff 12929

View Options

ps/trunk/binaries/data/tools/atlas/lists.xml

Loading...
Wildfire Games · Phabricator