Page MenuHomeWildfire Games

Medium ↔ Normal in map sizes
ClosedPublic

Authored by Nescio on Aug 3 2020, 12:15 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23939: Switch Medium and Normal map sizes.
Summary

There are seven map sizes in 0 A.D.:

  1. tiny (2 × 64 = 128 tiles)
  2. small (3 × 64 = 192 tiles)
  3. medium (4 × 64 = 256 tiles); default
  4. normal (5 × 64 = 320 tiles)
  5. large (6 × 64 = 384 tiles)
  6. very large (7 × 64 = 448 tiles)
  7. giant (8 × 64 = 512 tiles)

Now from a linguistic point of view, it's a bit odd that the third option is called “medium” and the fourth “normal”.
The fourth option is both the mean and the median of all map sizes; therefore “Medium” would be the correct name (medium (adjective) means “About halfway between two extremes of size or another quality; average.”).
The third option is the default map size; therefore “Normal” would be the correct name (normal (adjective) means “Conforming to a standard; usual, typical, or expected.”).
This patch thus simply swaps the “Medium” and “Normal” names.

Test Plan

Ought to be uncontroversial.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Aug 3 2020, 12:15 PM
Owners added a subscriber: Restricted Owners Package.Aug 3 2020, 12:15 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2853/display/redirect

Nescio edited the summary of this revision. (Show Details)Aug 3 2020, 12:23 PM
Nescio removed a subscriber: Restricted Owners Package.
Nescio requested review of this revision.Aug 3 2020, 12:58 PM
wraitii accepted this revision.Aug 3 2020, 1:41 PM
wraitii added a subscriber: wraitii.

Makes sense to me.

This revision is now accepted and ready to land.Aug 3 2020, 1:41 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Aug 6 2020, 9:57 AM