Move gamesetup_mp to a separate directory
ClosedPublic
Actions

Authored by elexis on Apr 7 2017, 6:27 PM.

Details

Reviewers

bb
wraitii

Commits

rP19380: Move multiplayer host and join page to a new directory, as it is not related…

Summary

The gamesetup_mp page has for any reason been put into the gamesetup/ directory, despite being entirely independent and not sharing anything.
The dialog is about entering the IP address of the game to join or starting a networked host.
Perhaps we could also rename it if someone has an idea.

Test Plan

Patch is trivial, so not much to test at all.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Apr 7 2017, 6:27 PM

wraitii accepted this revision.Apr 7 2017, 6:34 PM

This revision is now accepted and ready to land.Apr 7 2017, 6:34 PM

Closed by commit rP19380: Move multiplayer host and join page to a new directory, as it is not related… (authored by elexis). · Explain WhyApr 7 2017, 6:45 PM

This revision was automatically updated to reflect the committed changes.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/709/ for more details.

Harbormaster completed remote builds in B1036: Diff 1130.Apr 7 2017, 7:12 PM

elexis mentioned this in D619: GUI should include entire directories instead of all files individually.Jun 10 2017, 12:41 AM