Page MenuHomeWildfire Games
Differential D2989

Reuse "APPROACHING"-state in formation combat.
ClosedPublic
Actions

Authored by Freagarach on Sep 4 2020, 10:49 AM.

Details

Reviewers
Silier
wraitii
bb
Commits
rP24032: Reuse "APPROACHING"-state in formation combat.
Summary

Noticed by @wraitii in D1971#inline-53877.

Test Plan

Verify this is correct and formation can still attack and follow targets.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:349ESLintBear (consistent-return)ESLintBear (consistent-return)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:800ESLintBear (no-else-return)ESLintBear (no-else-return)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:1063ESLintBear (key-spacing)ESLintBear (key-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:2069ESLintBear (operator-linebreak)ESLintBear (operator-linebreak)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:2227ESLintBear (no-trailing-spaces)ESLintBear (no-trailing-spaces)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:2529ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3146ESLintBear (semi)ESLintBear (semi)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3360ESLintBear (indent)ESLintBear (indent)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3410ESLintBear (no-unneeded-ternary)ESLintBear (no-unneeded-ternary)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3550ESLintBear (comma-spacing)ESLintBear (comma-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3607ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3607ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3736ESLintBear (spaced-comment)ESLintBear (spaced-comment)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3909ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:3909ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4052ESLintBear (no-shadow)ESLintBear (no-shadow)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4150ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4150ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4236ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4236ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4241ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4241ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4246ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4246ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Warningbinaries/data/mods/public/simulation/components/UnitAI.js:4261ESLintBear (object-curly-spacing)ESLintBear (object-curly-spacing)
Unit
No Unit Test Coverage
Build Status
Buildable 13079
Build 25902: Vulcan BuildJenkins
Build 25901: Vulcan Build (macOS)Jenkins
Build 25900: Vulcan Build (Windows)Jenkins
Build 25899: arc lint + arc unit

Event Timeline

Freagarach created this revision.Sep 4 2020, 10:49 AM
Harbormaster completed remote builds in B13079: Diff 13389.Sep 4 2020, 10:55 AM
Freagarach requested review of this revision.Sep 4 2020, 10:55 AM
bb accepted this revision.Sep 4 2020, 11:17 PM
bb added a subscriber: bb.

Looks correct from the code, individuals do the same too.
Checking all pushOrderFront calls in the unitIA shows this patch is complete

This revision is now accepted and ready to land.Sep 4 2020, 11:17 PM
Silier accepted this revision.Sep 6 2020, 10:45 AM

nice find

Closed by commit rP24032: Reuse "APPROACHING"-state in formation combat. (authored by Freagarach). · Explain WhySep 10 2020, 9:51 AM
This revision was automatically updated to reflect the committed changes.
Freagarach added a commit: rP24032: Reuse "APPROACHING"-state in formation combat..
Freagarach added a comment.Sep 10 2020, 10:54 AM

Thanks for the review @Angen and @bb :)

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
components/
6 lines

Diff 13389

View Options

binaries/data/mods/public/simulation/components/UnitAI.js

Loading...
Wildfire Games · Phabricator