var -> let
comments
spaces
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP24024: Clean Formation.js
Jenkins is happy, check CC
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
builderr-release-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1507/display/redirect
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
4 ↗ | (On Diff #13433) | full stop (.) |
10 ↗ | (On Diff #13433) | idem |
17 ↗ | (On Diff #13433) | idem |
26 ↗ | (On Diff #13433) | idem |
29 ↗ | (On Diff #13433) | idem |
33 ↗ | (On Diff #13433) | Replace \" with opening “ and closing ” quotation marks (you can just copy and paste). |
40 ↗ | (On Diff #13433) | Sloppyness [sic] → Sloppiness (cf. happiness). |
44 ↗ | (On Diff #13433) | full stop |
54 ↗ | (On Diff #13433) | idem |
59 ↗ | (On Diff #13433) | idem |
69 ↗ | (On Diff #13433) | idem |
73 ↗ | (On Diff #13433) | Capital, full stop. |
237 ↗ | (On Diff #13433) | Capital, full stop. |
245–250 ↗ | (On Diff #13433) | full stops |
323 ↗ | (On Diff #13433) | Initialize |
380 ↗ | (On Diff #13433) | Capital, full stop. |
451–452 ↗ | (On Diff #13433) | Two white lines? |
463 ↗ | (On Diff #13433) | reinitialized |
489 ↗ | (On Diff #13433) | comma |
847 ↗ | (On Diff #13433) | full stop |
861 ↗ | (On Diff #13433) | Capital |
864 ↗ | (On Diff #13433) | full stop |
966–967 ↗ | (On Diff #13433) | Capital, full stop. |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
69 ↗ | (On Diff #13433) | I missed this |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
33 ↗ | (On Diff #13437) | Does the default option have a name? |
517 ↗ | (On Diff #13437) | biggish → large |
668 ↗ | (On Diff #13437) | ['Unknown'] is better written in dot notation. |
702 ↗ | (On Diff #13437) | What makes a formation special? |
729 ↗ | (On Diff #13437) | Switch → Alternate |
783 ↗ | (On Diff #13437) | function (o) { → function(o) { |
785 ↗ | (On Diff #13437) | full stop |
786 ↗ | (On Diff #13437) | Capital |
920 ↗ | (On Diff #13437) | if when → if and when or if? |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
37 ↗ | (On Diff #13439) | width/depth → width-to-depth ratio |
44 ↗ | (On Diff #13439) | width depth ratio → width-to-depth ratio |
467 ↗ | (On Diff #13439) | undo typo . * @ |
489 ↗ | (On Diff #13439) | insert the after as |
490 ↗ | (On Diff #13439) | right → correct? |
600 ↗ | (On Diff #13439) | No comment? |
631 ↗ | (On Diff #13439) | No comment? |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
600 ↗ | (On Diff #13439) | dont have to comment everything |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
769 ↗ | (On Diff #13439) | r + 1 |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
632 ↗ | (On Diff #13439) | but name says clearly what it does |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
702 ↗ | (On Diff #13437) | Line 23? |
20 ↗ | (On Diff #13439) | The speed of a formation is the speed of its slowest member multiplied by this. |
23 ↗ | (On Diff #13439) | serial comma (, and) |
40 ↗ | (On Diff #13439) | Add closing parenthesis ()) or rephrase. |
49 ↗ | (On Diff #13439) | possible within → possible, given |
63 ↗ | (On Diff #13439) | closer or further to → closer to or further from |
66 ↗ | (On Diff #13439) | idem |
69 ↗ | (On Diff #13439) | Give a → A |
70 ↗ | (On Diff #13439) | “animationVariant1” |
73 ↗ | (On Diff #13439) | column/box → column and box |