Page MenuHomeWildfire Games

Clean Formation.js
ClosedPublic

Authored by Silier on Sep 6 2020, 12:25 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24024: Clean Formation.js
Summary

var -> let
comments
spaces

Test Plan

Jenkins is happy, check CC

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/simulation/components/Formation.js:668ESLintBear (dot-notation)ESLintBear (dot-notation)
Warningbinaries/data/mods/public/simulation/components/Formation.js:668JSHintBearJSHintBear
Warningbinaries/data/mods/public/simulation/components/Formation.js:783ESLintBear (space-before-function-paren)ESLintBear (space-before-function-paren)
Unit
No Unit Test Coverage
Build Status
Buildable 13126
Build 26065: Vulcan BuildJenkins
Build 26064: Vulcan Build (macOS)Jenkins
Build 26063: Vulcan Build (Windows)Jenkins
Build 26062: arc lint + arc unit

Event Timeline

Silier created this revision.Sep 6 2020, 12:25 PM

Successful build - Chance fights ever on the side of the prudent.

builderr-release-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1507/display/redirect

Silier requested review of this revision.Sep 6 2020, 12:35 PM
Silier planned changes to this revision.Sep 6 2020, 12:37 PM

more jenkins

Silier updated this revision to Diff 13433.Sep 6 2020, 12:44 PM
Silier added a reviewer: Restricted Owners Package.Sep 6 2020, 12:58 PM
Nescio added a subscriber: Nescio.Sep 6 2020, 1:04 PM
Nescio added inline comments.
binaries/data/mods/public/simulation/components/Formation.js
4

full stop (.)

10

idem

17

idem

26

idem

29

idem

33

Replace \" with opening “ and closing ” quotation marks (you can just copy and paste).
No space at the end (. '>").

40

Sloppyness [sic] → Sloppiness (cf. happiness).
full stop

44

full stop

54

idem

59

idem

69

idem

73–74

Capital, full stop.

238

Capital, full stop.

246–251

full stops

323

Initialize

381

Capital, full stop.

451–452

Two white lines?

463

reinitialized

489–491

comma

847

full stop

861

Capital

863–864

full stop

967–968

Capital, full stop.

Silier added inline comments.Sep 6 2020, 1:28 PM
binaries/data/mods/public/simulation/components/Formation.js
40

since it is refering to element name, I would avoid changes in template so pass

238

see next line

Silier updated this revision to Diff 13436.Sep 6 2020, 1:30 PM

more comments

Silier planned changes to this revision.Sep 6 2020, 1:32 PM
Silier added inline comments.
binaries/data/mods/public/simulation/components/Formation.js
69

I missed this

Nescio added inline comments.Sep 6 2020, 1:42 PM
binaries/data/mods/public/simulation/components/Formation.js
33

“fillToTheCenter”

249–250
template,
 * e.g.

?

823

full stop or colon (:)?

Silier updated this revision to Diff 13437.Sep 6 2020, 1:58 PM
Silier marked an inline comment as not done.
Nescio added inline comments.Sep 6 2020, 2:59 PM
binaries/data/mods/public/simulation/components/Formation.js
33

Does the default option have a name?
and the center of each row to the sides.and each row from the center to the sides.
vulerable [sic] → vulnerable
are right in the centerare in the center

517

biggishlarge

668

['Unknown'] is better written in dot notation.
What does that mean?

702

What makes a formation special?

729

SwitchAlternate

783

function (o) {function(o) {

785

full stop

786

Capital

919

if whenif and when or if?

Silier added a subscriber: Itms.Sep 6 2020, 3:11 PM
Silier added inline comments.
binaries/data/mods/public/simulation/components/Formation.js
33

most likely it does not have name

668

no idea, @Itms ?, not in cc idc

702

not using shape but name ?
maybe they planed more like that one

Silier updated this revision to Diff 13439.Sep 6 2020, 3:24 PM
Silier removed a subscriber: Itms.
Nescio added inline comments.Sep 6 2020, 3:38 PM
binaries/data/mods/public/simulation/components/Formation.js
37

width/depthwidth-to-depth ratio

44

width depth ratiowidth-to-depth ratio

467

undo typo . * @

489–491

insert the after as
hight [sic] → height

490

rightcorrect?

600

No comment?

631

No comment?

Silier added inline comments.Sep 6 2020, 3:44 PM
binaries/data/mods/public/simulation/components/Formation.js
600

dont have to comment everything

Nescio added inline comments.Sep 6 2020, 3:53 PM
binaries/data/mods/public/simulation/components/Formation.js
73–74

Replace:

// Distance

with:

/**
 * Distance
 */

See e.g. lines 177 to 179.

632

This thing is nearly two hundred lines long.

Nescio added inline comments.Sep 6 2020, 3:56 PM
binaries/data/mods/public/simulation/components/Formation.js
769

r + 1

Silier added inline comments.Sep 6 2020, 4:01 PM
binaries/data/mods/public/simulation/components/Formation.js
632

but name says clearly what it does

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2020, 4:09 PM
Closed by commit rP24024: Clean Formation.js (authored by Silier). · Explain Why
This revision was automatically updated to reflect the committed changes.
Nescio added inline comments.Sep 6 2020, 4:19 PM
binaries/data/mods/public/simulation/components/Formation.js
20

The speed of a formation is the speed of its slowest member multiplied by this.

23

serial comma (, and)

40

Add closing parenthesis ()) or rephrase.

49

possible withinpossible, given
, andand

63

closer or further tocloser to or further from

66

idem

70

Give aA

71

“animationVariant1”
animation2 → “animationVariant2
animationvariantsanimation variants

73–74

column/boxcolumn and box

702

Line 23?