var -> let
comments
spaces
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP24024: Clean Formation.js
Jenkins is happy, check CC
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK Severity Location Code Message Warning binaries/data/mods/public/simulation/components/Formation.js:668 ESLintBear (dot-notation) ESLintBear (dot-notation) Warning binaries/data/mods/public/simulation/components/Formation.js:668 JSHintBear JSHintBear Warning binaries/data/mods/public/simulation/components/Formation.js:783 ESLintBear (space-before-function-paren) ESLintBear (space-before-function-paren) - Unit
No Unit Test Coverage - Build Status
Buildable 13123 Build 26053: Vulcan Build Jenkins Build 26052: Vulcan Build (macOS) Jenkins Build 26051: Vulcan Build (Windows) Jenkins Build 26050: arc lint + arc unit
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
builderr-release-macos.txt /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libsimulation2.a(precompiled.o) has no symbols /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libatlas.a(precompiled.o) has no symbols
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1507/display/redirect
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
4 | full stop (.) | |
10 | idem | |
17 | idem | |
26 | idem | |
29 | idem | |
33 | Replace \" with opening “ and closing ” quotation marks (you can just copy and paste). | |
40 | Sloppyness [sic] → Sloppiness (cf. happiness). | |
44 | full stop | |
54 | idem | |
59 | idem | |
69 | idem | |
73 | Capital, full stop. | |
237 | Capital, full stop. | |
245–250 | full stops | |
323 | Initialize | |
380 | Capital, full stop. | |
451–452 | Two white lines? | |
463 | reinitialized | |
489 | comma | |
847 | full stop | |
861 | Capital | |
864 | full stop | |
966–967 | Capital, full stop. |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
69 | I missed this |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
33 | Does the default option have a name? | |
517 | biggish → large | |
668 | ['Unknown'] is better written in dot notation. | |
702 | What makes a formation special? | |
729 | Switch → Alternate | |
783 | function (o) { → function(o) { | |
785 | full stop | |
786 | Capital | |
919 | if when → if and when or if? |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
600 | dont have to comment everything |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
769 | r + 1 |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
632 | but name says clearly what it does |
binaries/data/mods/public/simulation/components/Formation.js | ||
---|---|---|
20 | The speed of a formation is the speed of its slowest member multiplied by this. | |
23 | serial comma (, and) | |
40 | Add closing parenthesis ()) or rephrase. | |
49 | possible within → possible, given | |
63 | closer or further to → closer to or further from | |
66 | idem | |
70 | Give a → A | |
71 | “animationVariant1” | |
73 | column/box → column and box | |
702 | Line 23? |