Page MenuHomeWildfire Games

Don't uselessly traffic constant statuseffect translatable strings and icons through the guiinterface
ClosedPublic

Authored by bb on Nov 17 2020, 10:26 PM.

Details

Summary

rP24162 moved the translatable statuseffect strings from the template to a json, and access them from the gui directly. Therefore we don't need to process them in the sim anymore (the sim doesn't need them). Therefore don't process them.

Test Plan

Create some statuseffect and see the front doesn't fall.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bb created this revision.Nov 17 2020, 10:26 PM
bb retitled this revision from Don't uselessly traffic constant translatable statuseffect string through the guiinterface to Don't uselessly traffic constant statuseffect translatable strings and icons through the guiinterface.Nov 17 2020, 10:29 PM
bb edited the summary of this revision. (Show Details)

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1957/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3616/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3067/display/redirect

bb requested review of this revision.Nov 17 2020, 10:31 PM
wraitii accepted this revision.Nov 18 2020, 7:38 AM
This revision is now accepted and ready to land.Nov 18 2020, 7:38 AM
This revision was landed with ongoing or failed builds.Nov 18 2020, 9:25 AM
This revision was automatically updated to reflect the committed changes.