Description
Details
- Auditors
bb - Committed
Freagarach Nov 11 2020, 9:07 PM - Reviewer
- wraitii
- Differential Revision
- D2808: Allow resistance to StatusEffects.
- Parents
- rP24161: Store turret positions in map files.
- Branches
- Unknown
- Tags
- Build Status
Buildable 13583 Build 27618: Post-Commit Build Jenkins Build 27617: Post-Commit Build (macOS) Jenkins
Event Timeline
| /ps/trunk/binaries/data/mods/public/simulation/helpers/Attacking.js | ||
|---|---|---|
| 122–124 | Yelled a couple of times at these, to remove them here. The are never used down the line (the gui gets it directly from the json) and passing translatable strings through the guiinterface might be considered unwanted (which is happening). | |
I think the 'fetch the GUI data exclusively from JSON' was a regression, though we didn't notice at the time. The problem is modifiers: these are actually defined in the template (in the status effects receiver really). To show their effect in the GUI, we need to pull the data from the template. If we want the tooltip to explain the modifiers, it becomes intractable -> the GUI must show template-specific data.
While _technically_ it ought to be possible to pull the data from the template in the GUI, this just seems inferior to the easy solution -> pass the raw translatable strings from the sim to the GUI. The main drawback I can see is that it _could_ be a performance problem, but that doesn't really seem concerning enough to warrant particular handling right now.
(Conceptually, I don't think this is different from getting the identity classes from the sim to the GUI).