Page MenuHomeWildfire Games

[SM60] API changes
Needs ReviewPublic

Authored by wraitii on Wed, Nov 18, 9:09 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Trac Tickets
#5859
Summary

Windows user -> please test https://github.com/wraitii/0ad/tree/sm60

Mostly minor stuff:

  • JSVOID->JSUNDEFINED
  • compartment behaviours change
  • Bug 1308236 - avoid ambiguous comparison
  • Bug 1421358, REFRESH_FRAME was removed. TBH not sure this is useful, so go APIé
  • ClassOps changes
  • Proxy improvements post SM60
Test Plan

Compile on all major platforms. Run the game. Run tests. Play online.

Event Timeline

wraitii created this revision.Wed, Nov 18, 9:09 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3085/display/redirect

wraitii edited the summary of this revision. (Show Details)Thu, Nov 19, 6:02 PM
wraitii edited the test plan for this revision. (Show Details)
wraitii updated this revision to Diff 14080.Thu, Nov 19, 6:35 PM

Rebase for clean looking diff

wraitii added inline comments.Thu, Nov 19, 6:40 PM
source/gui/Scripting/JSInterface_CText.cpp
50 ↗(On Diff #14080)

errrr

source/gui/Scripting/JSInterface_GUIProxy_impl.h
23

This bit is required by SM, it static_asserts it. It doesn't seem to be required _by itself_, but they did it, so I'll use it.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3679/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2024/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3126/display/redirect

wraitii requested review of this revision.Thu, Nov 19, 7:23 PM
wraitii updated this revision to Diff 14089.Thu, Nov 19, 8:36 PM

Fix compilation and remove some additional proxy changes that I ought to do after the migration, not within.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3687/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/3134/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/2032/display/redirect