Differential D3311

[gui] show gather rates for build and train tooltips
Needs ReviewPublic
Actions

Authored by Nescio on Jan 9 2021, 8:28 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

Knowing which resources an unit can gather is important information, especially for people new to the game (or a mod).
There are gather rates and resource dropsite tooltip lines, which are displayed in the full entity details (right-click on icon), when hovering over an icon in the structure tree, and by the “attack and resistance” pop-up in the central selection panel.
However, gather rates are currently not displayed in the tooltips that pop up when hovering over an icon in the building and training right selection panels. This patch adds them there too, because this is useful to know before buying something. How it looks with the “detailed tooltips” setting off:

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Severity	Location	Code	Message
Warning	binaries/data/mods/public/gui/session/selection_panels.js:50	ESLintBear (default-case)	ESLintBear (default-case)
Warning	binaries/data/mods/public/gui/session/selection_panels.js:61	ESLintBear (default-case)	ESLintBear (default-case)
Warning	binaries/data/mods/public/gui/session/selection_panels.js:700	ESLintBear (default-case)	ESLintBear (default-case)
Warning	binaries/data/mods/public/gui/session/selection_panels.js:735	ESLintBear (no-multi-spaces)	ESLintBear (no-multi-spaces)

Unit

No Unit Test Coverage

Build Status

Buildable 14815
Build 31855: Vulcan Build	Jenkins
Build 31854: Vulcan Build (macOS)	Jenkins
Build 31853: Vulcan Build (Windows)	Jenkins
Build 31852: arc lint + arc unit

Event Timeline

Nescio created this revision.Jan 9 2021, 8:28 PM

Owners added a subscriber: Restricted Owners Package.Jan 9 2021, 8:28 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2737/display/redirect for more details.

Harbormaster completed remote builds in B14815: Diff 15082.Jan 9 2021, 8:37 PM

Nescio requested review of this revision.Jan 9 2021, 8:37 PM

Doesn't that make it a bit too crowded, I'm not sure how much is too much for tooltips. Wouldn't it make more sense to see attack?

I do think this is the wrong way to go about this ultimately. Learning the stats of things and how to play the game shouldn't be done by having to look at various tooltips, we just need a better in-game encyclopaedia.

This isn't much code, I can't really argue it hurts to have, but I think we need to rethink this kind of thing. Just adding more information to tooltips isn't a solution IMO.

I think we need to rethink this kind of thing. Just adding more information to tooltips isn't a solution IMO.

Yes, I agree, in general. However, there is infantry in game that can gather and infantry that can't, just looking at their name and icon won't necessarily give you this information, and not everyone knows what classes to look for, hence this patch to make it more explicit.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

gui/

session/

selection_panels.js

7 lines

Diff 15082

View Options

binaries/data/mods/public/gui/session/selection_panels.js

[gui] show gather rates for build and train tooltipsNeeds ReviewPublicActions