Differential D3314

[gameplay] increase defensive structure vision range
ClosedPublic
Actions

Authored by Nescio on Jan 10 2021, 3:22 PM.

Details

Reviewers

borg-

Group Reviewers

Balancing

Commits

rP24540: [Gameplay A24] - Increase defensive structure vision range.

Summary

Due to the new way attack range is calculated, large structures can shoot further than they can see. To compensate for that, this patch therefore raises their vision range to 100, which should be enough for most situations. (The possible exception is when structures get a large elevation bonus from being placed on high terrain.)
For comparison, infantry has a vision range of 80, cavalry of 92, elephants of 100.

Test Plan

Basically agree.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 10 2021, 3:22 PM

Owners added a subscriber: Restricted Owners Package.Jan 10 2021, 3:22 PM

Nescio mentioned this in D3297: [gameplay] unify ranged soldier (and structure) attack ranges.Jan 10 2021, 3:27 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2745/display/redirect for more details.

Harbormaster completed remote builds in B14832: Diff 15098.Jan 10 2021, 3:30 PM

Nescio requested review of this revision.Jan 10 2021, 3:30 PM

Well, this is a necessary change. It does not affect balance to the point of worrying. My only concern was still being able to get around the enemy without being seen on normal size or larger maps, and that is still possible.
Give army_camp an adequate range vision compared to cc/fortress.

This revision is now accepted and ready to land.Jan 11 2021, 4:13 AM

Closed by commit rP24540: [Gameplay A24] - Increase defensive structure vision range. (authored by Freagarach). · Explain WhyJan 11 2021, 10:24 AM

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP24540: [Gameplay A24] - Increase defensive structure vision range..