Page MenuHomeWildfire Games

NetClient: don't LOGERROR when flushing messages while disconnected.
ClosedPublic

Authored by wraitii on Wed, Jan 13, 6:14 PM.

Details

Summary

The NetClient code is now threaded, and this means it can try to flush messages while 'knowingly' being disconnected.
This can be avoided by storing some state.

Test Plan

Reproduction can be tricky, but going in-game and having the host quit should do it.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Wed, Jan 13, 6:14 PM

Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libnetwork_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/Co

See https://jenkins.wildfiregames.com/job/macos-differential/2848/display/redirect for more details.

wraitii requested review of this revision.Wed, Jan 13, 6:26 PM
Stan added a subscriber: Stan.Wed, Jan 13, 6:34 PM

Years, but LGTM.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jan 15, 8:55 AM
This revision was automatically updated to reflect the committed changes.