Build is green

builderr-debug-macos.txt
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/C

See https://jenkins.wildfiregames.com/job/macos-differential/3002/display/redirect for more details.

It's intentional that swordsmen have Unit+!Ship and macemen don't: swordsmen inflict hack damage, making them effective vs all units, whereas macemen (like elephants) inflict crush damage, which is effective vs structures and siege engines, but not really vs soldiers.

In D3442#152324, @Nescio wrote:

It's intentional that swordsmen have Unit+!Ship and macemen don't: swordsmen inflict hack damage, making them effective vs all units, whereas macemen (like elephants) inflict crush damage, which is effective vs structures and siege engines, but not really vs soldiers.

I guess I should give them "!Ship" like Elephant then ?

Or just leave them with no preferences at all, elephants too.

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/3005/display/redirect for more details.

Can they attack ships at all? (And should they)

In D3442#152384, @Stan wrote:

Can they attack ships at all? (And should they)

They can if the ship is on the shore. I would argue they shouldn't, hence the 'non-preferred' status.

Is having a preferred class as fast as having none at all?

They can if the ship is on the shore. I would argue they shouldn't, hence the 'non-preferred' status.

If they shouldn't then you can use

<RestrictedClasses datatype="tokens">Ship</RestrictedClasses>

In D3442#152395, @Nescio wrote:

Is having a preferred class as fast as having none at all?

No, it's definitely slower, but it's not like I've added it to the core of any army here.

They can if the ship is on the shore. I would argue they shouldn't, hence the 'non-preferred' status.

If they shouldn't then you can use

Should have worded "they shouldn't attack those first". I think it's OK that ships can be targeted.

Yeah, I think it's fine they could attack ships, it's not something that'll happen frequently.
However, I'm unconvinced adding the proposed preferred class is really necessary, for the same reason.

In D3442#152399, @Nescio wrote:

Yeah, I think it's fine they could attack ships, it's not something that'll happen frequently.
However, I'm unconvinced adding the proposed preferred class is really necessary, for the same reason.

My main reason for adding it is that Spearmen/Swordsman/Pikeman have it, and I think for consistency Macemen should too, and elephants probably as well. Otherwise it should probably be removed there too.

The pikemen and swordsmen don't have !Ship, only axemen and swordsmen do, see https://code.wildfiregames.com/D2851#123342 as for why.

In D3442#152403, @Nescio wrote:

The pikemen and swordsmen don't have !Ship, only axemen and swordsmen do, see https://code.wildfiregames.com/D2851#123342 as for why.

They indirectly have, since Human implies !Ship