See title
Details
Details
- Reviewers
wraitii - Commits
- rP25379: Map browser fixes and improvements
- Trac Tickets
- #6045
Entry map should filter.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- temp
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 17065 Build 39177: arc lint + arc unit
Event Timeline
Comment Actions
I'm not sure what this does? It also seems to not work right, I can't see the "random" option?
Comment Actions
Thanks for the patch. Can you add context?
binaries/data/mods/public/gui/maps/mapbrowser/grid/MapGridBrowser.js | ||
---|---|---|
59 | You might want translate with context here. Single words might not get translated properly without proper context. |
Comment Actions
I understand the "filter random" bit now, but not the rest, and it seems you broke "random" when not using the input filter.
I am still not quite sure what you mean by 'input filter'
Comment Actions
Doing it myself since there's a few other issues.
- Random is filtered correctly
- When in 'fallback to all' mode, selecting something works (#6165).
- Fix hotkeys being broken.
- Clear filters when reopening the map browser (seems natural).
Comment Actions
Translate with context and don't bring in code already committed. Merging once green.