To avoid the line break for the Watch Replay button it needs to be quite long especially for the Greek language. I think the best solution might be to keep the line break and just increase the height for the Watch Replay and Continue button.
Details
Details
- Reviewers
marder bb - Commits
- rP25877: Enlarge "Watch Replay" button in summary screen for long translations
- Trac Tickets
- #6024
You could apply the patch and check if it looks good for all languages.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
To avoid the line break for Greek you would have to make the buttons even longer, it might be a better solution to focus more on height and keep the line break.
Comment Actions
Tried it for different languages (not all) and found no problems. Text fits nicely in the box / or at least better than before, in the case of greek.
Comment Actions
There is the longStrings language too which you can generate: running python3 source/tools/i18n/generateDebugTranslation.py --long will generate a new language containing for every string the longest translation among all languages, this way you can test a whether gui-items are large enough for all languages.
If one searches a bit with that one will find many more places with a similar issue. Don't want to fix the world here, (so accepting), but feel free to make patches for it (grouping some together is fine, but keep the patches reasonably small for review).
longstring is happy about this button now.
| binaries/data/mods/public/gui/summary/summary.xml | ||
|---|---|---|
| 186 ↗ | (On Diff #18256) | height of 37 pixels seems weird, but can't improve upon it. |