Pointed out by a clang warning.
Details
Details
- Reviewers
wraitii - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Owners Package (Owns No Changed Paths) - Commits
- rP19559: Don't move temporaries, so possibly allowing for copy elision.
-
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/992/ for more details.
Comment Actions
I've noticed that one too, it's
warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move]
I'll check locally if this handles all of those warnings unless someone does it first. Ought to be safe to do.