Differential D430
Don't send useless "Invalid command" debug warnings when regaining capture points Authored by Sandarac on May 5 2017, 11:25 PM.
Details
When setting g_DebugCommands to true in Commands.js, many dozens of Invalid command: attack target is not owned by enemy of player warnings will be logged when a player tries to regain capture points from one of its own structures. This is very annoying when trying to debug the AI (Petra already has checks to make sure targets are owned by enemies). I guess this may have been overlooked in rP16550 or some other related commit that dealt with capturing. Set g_DebugCommands to true in Commands.js, and run a game or replay with several Petra bots. Whenever Petra tries to regain capture points from one of its own structures, a warning will be logged. With this diff, these false positives won't be sent anymore.
Diff Detail
Event TimelineComment Actions Build is green Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! http://jw:8080/job/phabricator/1025/ for more details. Comment Actions Thanks leper, i've missed that one
| ||||||||||||||||