Add escapeText to take backslash characters in paths into account.
Details
Details
- Reviewers
elexis vladislavbelov - Commits
- rP26733: Escapes paths in user report terms to fix invisible backslashes on Windows.
- Trac Tickets
- #6475
Windows: Check the terms.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
builderr-debug-macos.txt fatal error: fatal errorfatal errorfile '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was built: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was builtfatal error: : file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was built notefile '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was built: please rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch' note: please rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch' note: please rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch' note: please rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch' 1 error generated. make[1]: *** [obj/graphics_Debug/MiniMapTexture.o] Error 1 make[1]: *** Waiting for unfinished jobs.... 1 error generated. make[1]: *** [obj/graphics_Debug/CinemaManager.o] Error 1 1 error generated. make[1]: *** [obj/graphics_Debug/MapGenerator.o] Error 1 1 error generated. make[1]: *** [obj/graphics_Debug/MapReader.o] Error 1 make: *** [graphics] Error 2
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5883/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6974/display/redirect
Comment Actions
elexis suggests to remove the comment.
comment shouldnt be necessary since the only thing escapeText does is escape the backslash
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
builderr-debug-macos.txt fatal error: fatal errorfatal error: : file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was builtfile '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was builtfile '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was built note: please rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch' note: noteplease rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch': please rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch' fatal error: file '/Users/wfg/Jenkins/workspace/macos-differential/build/workspaces/gcc/../../../libraries/source/glad/include/glad/gl.h' has been modified since the precompiled header 'obj/graphics_Debug/precompiled.h.gch' was built note: please rebuild precompiled header 'obj/graphics_Debug/precompiled.h.gch' 1 error generated. make[1]: *** [obj/graphics_Debug/MiniMapTexture.o] Error 1 make[1]: *** Waiting for unfinished jobs.... 1 error generated. make[1]: *** [obj/graphics_Debug/CinemaManager.o] Error 1 1 error generated. make[1]: *** [obj/graphics_Debug/MapGenerator.o] Error 1 1 error generated. make[1]: *** [obj/graphics_Debug/MapReader.o] Error 1 make: *** [graphics] Error 2
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5884/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/6975/display/redirect
