GetSimulationState called with an unused argument
ClosedPublic
Actions

Authored by fatherbushido on May 12 2017, 11:33 AM.

Details

Reviewers

mimo
Sandarac
echotangoecho
elexis

Commits

rP19565: Remove a leftover argument in GetSimulationState call. Refs r18283. Reviewed by…

Summary

GetSimulationState is called with the -1 argument in AIInterface. (leftover)

Test Plan

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fatherbushido created this revision.May 12 2017, 11:33 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1160/ for more details.

Harbormaster completed remote builds in B1661: Diff 1864.May 12 2017, 2:12 PM

echotangoecho accepted this revision.May 12 2017, 2:27 PM

This revision is now accepted and ready to land.May 12 2017, 2:27 PM

GetSimulationState indeed doesn't take any arguments, good catch!

fatherbushido edited the summary of this revision. (Show Details)May 12 2017, 2:52 PM

I'll leave this here rP18283 (and mention that the patch is complete because all occurances of SimulationState( in JS don't have an argument after applying this diff and there are no cpp occurances of `SimulationState)

(rP18283)

Closed by commit rP19565: Remove a leftover argument in GetSimulationState call. Refs r18283. Reviewed by… (authored by fatherbushido). · Explain WhyMay 12 2017, 6:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

AIInterface.js

2 lines

Diff 1879

View Options

ps/trunk/binaries/data/mods/public/simulation/components/AIInterface.js

GetSimulationState called with an unused argumentClosedPublicActions