Add, at the ends of the band with the player's name, a badge with one, two or three lines depending on whether the civilization is in village, town or city phase.
Details
Details
- Reviewers
Freagarach - Trac Tickets
- #6849
- Check that the player's band (white lines and tooltip) is updated immediately upon a phase change, selecting different player entities from different roles, including Observer.
- Check that those who are not mutual allies can't see each other's phases.
- Check that those who are mutual allies see each other's phases.
- Check that observers can see everyone's phases.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 22210 Build 54267: Vulcan Build Jenkins Build 54266: Vulcan Build (macOS) Jenkins Build 54265: Vulcan Build (Windows)
Event Timeline
| binaries/data/mods/public/gui/session/selection_details.js | ||
|---|---|---|
| 321 ↗ | (On Diff #22116) | I wonder what is the best way to retrieve the phase here. @Freagarach, do you know? |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8278/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7189/display/redirect
Comment Actions
Nice feature!
We may need to take into account that this leaks information to enemies.
| binaries/data/mods/public/gui/session/selection_details.js | ||
|---|---|---|
| 321 ↗ | (On Diff #22116) | The playerState should have the current phase? |
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8862/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7191/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8863/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7192/display/redirect
Comment Actions
While true, the borders reveal the same info already. Also AoE even sends a message to inform everyone of phase ups.
I'd argue that without being told it's hard to realize that this is supposed to indicate current phase, maybe take inspiration from AoE and boonGui on how to be more explicit if phase information is deemed worth showing.
Comment Actions
Hey @sera, thanks for commenting.
I had checked the ways in which some (not all) GUIs indicate the phase, and found them interesting, but I didn't see a better way to replicate them in the default GUI without changing its basic structure. Another minor issue is that I'm not too enthusiastic about representing phases with Roman numerals, since most civilizations don't use them. The solution of counting the number of lines painted on a band, which in any case resembles the corresponding Roman numerals, allows us to escape the problem, even if the technology icon continues to use, as a metaphor, Roman numerals with serifs. Finally, I think that discovering interesting information through units and buildings can be more realistic and exciting than seeing it all the time on a table, but this is probably the most subjective and least important point of all. Sadly, yes, it is true that the meaning of the lines won't be obvious to a new player, but the same will be true for many other elements of the game (including the existence of phases), the phase information would always have been much less obvious without the patch, and there's also a tooltip that we could detail further if necessary.
About the different GUIs in general, I think there's a lot of potential in integrating the best of them, I'm not familiar with their histories but I know there's effort and good ideas invested in each one separately and it saddens me that these efforts and good ideas take different paths. I would love it if, little by little, we could put together the clearest virtues of the different GUIs to improve the default one. If I can help with that, even if it's just helping to organize and compile ideas, I'd be happy to. Maybe I'll open some thread or task about it in the future.