- User Since
- Aug 21 2021, 5:41 PM (83 w, 4 d)
Adding to default.cfg for the purpose of documenting the option. Not offering falling back to upstream default as the current value is problematic and possibly future values may take a decade for us to be relied on. Also what should constitute and invalid value may be stuff for discussion, so conveniently avoid that.
Sun, Mar 26
Fri, Mar 17
Adds configure option network.enetmtu.
Moves header and implementation from lowlevel to network.
Wed, Mar 15
Haven't forgotten the package ->packet change, was just waiting for more discussion to happen before pushing out a new version of the patch, will also wait a day or two to allow people to comment on making it configurable. Given the release still has no name we aren't in that much of a hurry.
How should the config option be named, network.mtu is about as misleading as ENET_HOST_DEFAULT_MTU. Any good suggestions?
The only change that upstream patch brings is that now server can specify a lower mtu which is then used for communication in both directions. This patch here doesn't make use of this.
Sun, Mar 12
Take care of review comments.
Sat, Mar 11
If we follow that there is no way to set pseudo mtu; right after creation and resetting peers after is already the most unlikely way to break in future
As for the choice of 1372, a rule of thumb I know says assume MTU 1400 and you most likely are fine, my guess this same rule is how ENET_HOST_DEFAULT_MTU = 1400 came to be. Then assume the idea was to use ENET_HOST_DEFAULT_MTU in the sense of MTU so we should deduct the ICMP/IPv4 from it.
Fri, Mar 10
Update copyright year and add full diff context
Feb 19 2023
base handler is a lot more obvious than erased handler, thanks.
Feb 18 2023
This patch doesn't demonstrate the need for erased handlers, could you add some doxy comments to make it clear how they are supposed to fit into the "new" system?
Feb 16 2023
Can't this be done via shaders? If you need an extra set of textures I'm afraid you'd end up with the demo only just like what happened with the damage textures.
Feb 15 2023
Feb 1 2023
If you switch to class syntax and change pretty much every line anyway, I suggest to use default method signature, static and private where appropriate and drop useless "this" refs. Maybe even switch to use doxy comments.
Jan 22 2023
Jan 20 2023
Jan 19 2023
Works with system premake now.
Jan 17 2023
- generated files should not be under version control.
- files under version control must not be changed by build scripts
Jan 16 2023
Jan 15 2023
Whatever version is in use at compile time. An upgrade to icu forces a recompile of spidermonkey. The spidermonkey package doesn't install any icu headers. Looks like a sanitized package.
Can build with --with-system-mozjs on Gentoo with or without this patch and have confirmed that with this patch mozjs-91 and nspr come after -idirafter. I also confirmed that this patch will break use of system premake.
Jan 14 2023
Oh, already noticed by Itms :)
Jan 13 2023
As requested by Stan making the patching conditional on python version being >= 3.11
Wouldn't this warrant it's own player schema?
Jan 10 2023
Some enums I can't associate with a lookup table, so those name variants I'd rather see dropped. No strong opinion tho.
The names NetModerationTables and LookupTable are supposed to match and I don't like either name in particular. NetModeration.h feels better to me.
Jan 7 2023
Jan 4 2023
Jan 3 2023
Quick look only.
Dec 30 2022
Data (word list) and code needs to be split. Also it might make sense to support multiple data files to support "language packs" via mods that can individually be enabled / shipped. The reason for this being a word may be perfectly fine in one language but not another, secondly easier maintenance by people actually speaking a certain language and lastly performance. Performance might not be critical in lobby but we should be careful for in-game.
Jul 24 2022
The overload for wchar is proprietary, so likely only available with msvc. Needs some ifdef here. Or better yet move to <filesystem>.
Dec 9 2021
It represents the fact that Rome was one of the most populous cities in the ancient world.
Nov 29 2021
"Ralph Sennhauser <firstname.lastname@example.org>", if nick is required "sera" is fine.
Sep 28 2021
Do you need to call parse multiple times? If not why do you need the method?
Sep 27 2021
If so, what should I use instead of debug_printf()?
You won't need the readme.txt anymore if you have support for help, worst case just run "pyrogenesis -help > readme.txt" as a postbuild command. So no duplication required.
IMHO the right approach is to change CmdLineArgs from an minimalist class to a proper command line parser where you register available options, does validation and has a help string for each.
Sep 20 2021
It'd be great but who knows how long it will take for someone to go out and make it.
Just write it as you like and get it committed to /binaries/data/mods/public, doesn't have to be a complete or perfect plan, a rundown of possibilities will already do, anything else I don't see ever having success indeed.
Sep 19 2021
making the addition of it to that file out of scope for this revision
Sep 18 2021
I suppose the bigger problem is that there isn't really a design plan/idea for how the civs should play and how many bonuses, unique techs a civ should have
Sep 14 2021
Aug 22 2021
Aug 21 2021
same, with context