Add brief explanations ("Alert nearby Female Citizens/Traders/vulnerable units to seek refuge." and "Unload nearby Female Citizens/Traders/vulnerable units.") to the tooltips of the alert buttons ("Raise an alert!" and "End the alert.").
Details
Details
Tested in the game.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 22208 Build 54261: Vulcan Build Jenkins Build 54260: Vulcan Build (macOS) Jenkins Build 54259: Vulcan Build (Windows)
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8861/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7190/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8293/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8294/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7204/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7205/display/redirect
Comment Actions
(Notice healers are support class as well, but don't get garrisoned. See in the templates (hint AlertRaiser) what class(es) is(/are) affected and make of that what you want. :) )
| binaries/data/mods/public/gui/session/selection_panels.js | ||
|---|---|---|
| 66 ↗ | (On Diff #22139) | This implies the button is present on the support units themselves. Maybe more something like Inform nearby support units to garrison to safety.? Where there is a more appropriate word for Inform but I'm not finding it now. ;P |
| 70 ↗ | (On Diff #22139) | Whilst we're changing it anyway. ^^ |
| 71 ↗ | (On Diff #22139) | It only unloads the units who were garrisoned by the alarm, not all support units. |
Comment Actions
Thanks, @Freagarach!
| binaries/data/mods/public/gui/session/selection_panels.js | ||
|---|---|---|
| 66 ↗ | (On Diff #22139) | "Alert"? :-) "Alert nearby support units to garrison to safety." or "Alert nearby support units to seek refuge."? |
| 70 ↗ | (On Diff #22139) | Good! |
| 71 ↗ | (On Diff #22139) | That's indeed what everyone would expect, but it's not the case. One can use the end-of-alert button to unload all the women in a civic center without having previously raised any alert. (I'm not super enthusiastic about these alerts, TBH.) |
Comment Actions
Thanks as always, @Freagarach. In the end I've specified the classes of units affected, because otherwise the behavior is very confusing. Hopefully we're closer to the commit. :-)
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7263/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8352/display/redirect
Comment Actions
@Freagarach, what are your thoughts? I tend to assign you to review pretty much everything GUI-related by default, but feel free to tell me if you're too busy and think I should diversify a bit. :-)
Comment Actions
I take a look when I can. :)
| binaries/data/mods/public/simulation/components/GuiInterface.js | ||
|---|---|---|
| 467 ↗ | (On Diff #22224) | I'd prefer ret.alertRaiser = {
classes: xyz
} |
Comment Actions
Great! Keeping alertRaiser, now a dictionary. In any case, feel free to let me know if at any point you see that I'm throwing too much on your plate.
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7336/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8425/display/redirect