Page MenuHomeWildfire Games
Differential D5095

add brief explanations to the tooltips of the alert buttons
ClosedPublic
Actions

Authored by abian on Aug 7 2023, 10:42 PM.

Details

Reviewers
Freagarach
Commits
rP27886: Add brief explanations to the tooltips of the alert buttons.
Trac Tickets
#6850
Summary

Add brief explanations ("Alert nearby Female Citizens/Traders/vulnerable units to seek refuge." and "Unload nearby Female Citizens/Traders/vulnerable units.") to the tooltips of the alert buttons ("Raise an alert!" and "End the alert.").

Test Plan

Tested in the game.

Diff Detail

Event Timeline

abian created this revision.Aug 7 2023, 10:42 PM
Vulcan added a comment.Aug 7 2023, 10:43 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/8861/display/redirect

Vulcan added a comment.Aug 7 2023, 10:58 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7190/display/redirect

abian published this revision for review.Aug 14 2023, 10:33 PM
abian updated this revision to Diff 22138.
abian updated this revision to Diff 22139.
abian edited the summary of this revision. (Show Details)
Vulcan added a comment.Aug 14 2023, 10:36 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8293/display/redirect

Vulcan added a comment.Aug 14 2023, 10:39 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8294/display/redirect

Vulcan added a comment.Aug 14 2023, 11:01 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7204/display/redirect

Harbormaster completed remote builds in B22224: Diff 22138.Aug 14 2023, 11:11 PM
Vulcan added a comment.Aug 14 2023, 11:17 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7205/display/redirect

Harbormaster completed remote builds in B22225: Diff 22139.Aug 14 2023, 11:24 PM
Freagarach added a comment.Aug 16 2023, 8:03 AM

(Notice healers are support class as well, but don't get garrisoned. See in the templates (hint AlertRaiser) what class(es) is(/are) affected and make of that what you want. :) )

binaries/data/mods/public/gui/session/selection_panels.js
66

This implies the button is present on the support units themselves. Maybe more something like Inform nearby support units to garrison to safety.? Where there is a more appropriate word for Inform but I'm not finding it now. ;P

75

Whilst we're changing it anyway. ^^

76

It only unloads the units who were garrisoned by the alarm, not all support units.

abian added a comment.Aug 25 2023, 4:23 PM

Thanks, @Freagarach!

binaries/data/mods/public/gui/session/selection_panels.js
66

"Alert"? :-) "Alert nearby support units to garrison to safety." or "Alert nearby support units to seek refuge."?
I would like to specify whether they're female citizens or traders (for the case of the market), but I think the variables to achieve this are "far" from the function.

75

Good!

76

That's indeed what everyone would expect, but it's not the case. One can use the end-of-alert button to unload all the women in a civic center without having previously raised any alert. (I'm not super enthusiastic about these alerts, TBH.)

Freagarach added inline comments.Sep 8 2023, 11:08 AM
binaries/data/mods/public/gui/session/selection_panels.js
66

Your second suggestion seems nice!

76

Sorry, you are correct indeed. Then Unloads all support units. seems fitting to me.

abian updated this revision to Diff 22224.Sep 8 2023, 5:37 PM
abian edited the summary of this revision. (Show Details)

Thanks as always, @Freagarach. In the end I've specified the classes of units affected, because otherwise the behavior is very confusing. Hopefully we're closer to the commit. :-)

Vulcan added a comment.Sep 8 2023, 5:38 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7263/display/redirect

Vulcan added a comment.Sep 8 2023, 5:46 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8352/display/redirect

Harbormaster completed remote builds in B22306: Diff 22224.Sep 8 2023, 5:55 PM
abian added a comment.Sep 24 2023, 4:08 PM

@Freagarach, what are your thoughts? I tend to assign you to review pretty much everything GUI-related by default, but feel free to tell me if you're too busy and think I should diversify a bit. :-)

Freagarach added a comment.Sep 25 2023, 11:16 AM

I take a look when I can. :)

binaries/data/mods/public/simulation/components/GuiInterface.js
467–469

I'd prefer

ret.alertRaiser = {
classes: xyz
}
abian updated this revision to Diff 22326.Sep 26 2023, 7:32 PM

Great! Keeping alertRaiser, now a dictionary. In any case, feel free to let me know if at any point you see that I'm throwing too much on your plate.

Vulcan added a comment.Sep 26 2023, 7:32 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7336/display/redirect

Vulcan added a comment.Sep 26 2023, 7:41 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8425/display/redirect

Harbormaster completed remote builds in B22399: Diff 22326.Sep 26 2023, 7:48 PM
Freagarach accepted this revision.Sep 27 2023, 8:17 AM

Looks good to me.

This revision is now accepted and ready to land.Sep 27 2023, 8:17 AM
This revision was landed with ongoing or failed builds.Oct 13 2023, 11:35 AM
Closed by commit rP27886: Add brief explanations to the tooltips of the alert buttons. (authored by Freagarach). · Explain Why
This revision was automatically updated to reflect the committed changes.
Freagarach added a commit: rP27886: Add brief explanations to the tooltips of the alert buttons..
Owners added a subscriber: Restricted Owners Package.Oct 13 2023, 11:35 AM

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
gui/
session/
17 lines
simulation/
components/
7 lines
4 lines

Diff 22326

View Options

binaries/data/mods/public/gui/session/selection_panels.js

Loading...
View Options

binaries/data/mods/public/simulation/components/AlertRaiser.js

Loading...
View Options

binaries/data/mods/public/simulation/components/GuiInterface.js

Loading...
Wildfire Games · Phabricator