Currently grass relies on old hacky shaders, because of that it has incorrect normals. Ideally grass should be fixed as it might be kind of blocker for PBR.
Details
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 22248 Build 54373: Vulcan Build Jenkins Build 54372: Vulcan Build (macOS) Jenkins Build 54371: Vulcan Build (Windows) Jenkins
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8308/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7219/display/redirect
If the textures are bogus and need fixing in the future anyway I'd say this patch shouldn't be committed. Sure it doesn't look all that nice but it's not bad enough to have to cover up the issue and possibly avoid having it fixed properly.
I wonder if those textures could be related to the flickering of shadows on grass during camera movement.
Generally I agree. Currently we're discussing with @wowgetoffyourcellphone what we can do from the art side. The only problem I'm worrying about is that updating content might be a slow process and we won't have time before the next release.
I wonder if those textures could be related to the flickering of shadows on grass during camera movement.
That might be unrelated, did you try to disable the "Cover whole map" option (graphics advanced)?
I don't think this one qualifies as a release blocker. Compared to the matchsettings issue which bricks gamesetup this one is utterly harmless. ;P
I wonder if those textures could be related to the flickering of shadows on grass during camera movement.
That might be unrelated, did you try to disable the "Cover whole map" option (graphics advanced)?
Enabling cut off revealed that even beyond the cut off distance the flickering remains, I played with a lot of options in graphic settings and nothing changes. The screen recording does barely show the issue, might be the encoding which "corrects" the issue to some extent. Will try if I can get it recorded somehow.
I agree that it's not critical. But I'd like to not have worse visual (because it was ok in Alpha 26). I understand that it's a hack but I'm going to refactor shaders for PBR anyway so I won't skip it.
Will try if I can get it recorded somehow.
Thanks!
Can't upload the video of the flickering grass here, so attached it to the forum post in the description.