Page MenuHomeWildfire Games

Uses per-vertex lighting for translucent objects until they are fixed
AcceptedPublic

Authored by vladislavbelov on Aug 19 2023, 2:33 PM.

Details

Summary

Currently grass relies on old hacky shaders, because of that it has incorrect normals. Ideally grass should be fixed as it might be kind of blocker for PBR.

https://wildfiregames.com/forum/topic/107877-overbrighteningcontrast-in-some-sprites-with-ogl-since-latest-renderer-changes-svn/

Test Plan
  1. Apply the patch
  2. Check visuals for grass

Event Timeline

vladislavbelov created this revision.Aug 19 2023, 2:33 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8308/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7219/display/redirect

vladislavbelov requested review of this revision.Aug 19 2023, 2:49 PM
sera added a subscriber: sera.Aug 20 2023, 10:55 PM

If the textures are bogus and need fixing in the future anyway I'd say this patch shouldn't be committed. Sure it doesn't look all that nice but it's not bad enough to have to cover up the issue and possibly avoid having it fixed properly.

I wonder if those textures could be related to the flickering of shadows on grass during camera movement.

In D5106#217019, @sera wrote:

If the textures are bogus and need fixing in the future anyway I'd say this patch shouldn't be committed. Sure it doesn't look all that nice but it's not bad enough to have to cover up the issue and possibly avoid having it fixed properly.

Generally I agree. Currently we're discussing with @wowgetoffyourcellphone what we can do from the art side. The only problem I'm worrying about is that updating content might be a slow process and we won't have time before the next release.

I wonder if those textures could be related to the flickering of shadows on grass during camera movement.

That might be unrelated, did you try to disable the "Cover whole map" option (graphics advanced)?

sera added a comment.Aug 21 2023, 8:27 PM
In D5106#217019, @sera wrote:

If the textures are bogus and need fixing in the future anyway I'd say this patch shouldn't be committed. Sure it doesn't look all that nice but it's not bad enough to have to cover up the issue and possibly avoid having it fixed properly.

Generally I agree. Currently we're discussing with @wowgetoffyourcellphone what we can do from the art side. The only problem I'm worrying about is that updating content might be a slow process and we won't have time before the next release.

I don't think this one qualifies as a release blocker. Compared to the matchsettings issue which bricks gamesetup this one is utterly harmless. ;P

I wonder if those textures could be related to the flickering of shadows on grass during camera movement.

That might be unrelated, did you try to disable the "Cover whole map" option (graphics advanced)?

Enabling cut off revealed that even beyond the cut off distance the flickering remains, I played with a lot of options in graphic settings and nothing changes. The screen recording does barely show the issue, might be the encoding which "corrects" the issue to some extent. Will try if I can get it recorded somehow.

In D5106#217030, @sera wrote:

I don't think this one qualifies as a release blocker. Compared to the matchsettings issue which bricks gamesetup this one is utterly harmless. ;P

I agree that it's not critical. But I'd like to not have worse visual (because it was ok in Alpha 26). I understand that it's a hack but I'm going to refactor shaders for PBR anyway so I won't skip it.

Will try if I can get it recorded somehow.

Thanks!

sera added a comment.Aug 22 2023, 8:50 AM

Can't upload the video of the flickering grass here, so attached it to the forum post in the description.

In D5106#217042, @sera wrote:

Can't upload the video of the flickering grass here, so attached it to the forum post in the description.

Thanks! Answered there.

After testing it, I can say this does patch up the original issue on OGL.

This revision is now accepted and ready to land.Aug 25 2023, 8:23 AM

Okay to commit, you think?

Okay to commit, you think?

Have you seen my forum PM with GIF about fixing grass properly?