Differential D5162

Reverts rP27695 as it breaks LOS update
ClosedPublic
Actions

Authored by vladislavbelov on Oct 12 2023, 10:43 PM.

Details

Reviewers

wraitii

Commits

rP27893: Reverts rP27695 as it breaks LOS update. Fixes #6844

Trac Tickets

#6844

Summary

Reverts rP27695 until we have a proper fix.

Test Plan

Apply the patch and compile the game
Check that LOS is updated smoothly like before the commit

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Severity	Location	Code	Message
Error	source/simulation2/components/CCmpPosition.cpp:1	LICENCE YEAR1	Inaccurate Copyright Year

Unit

Unit Tests Skipped

Build Status

Buildable 22467
Build 54996: Vulcan Build	Jenkins
Build 54995: Vulcan Build (macOS)	Jenkins
Build 54994: Vulcan Build (Windows)	Jenkins

Event Timeline

vladislavbelov created this revision.Oct 12 2023, 10:43 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7387/display/redirect

vladislavbelov updated the Trac tickets for this revision.Oct 12 2023, 10:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/8476/display/redirect

Harbormaster completed remote builds in B22467: Diff 22410.Oct 12 2023, 11:01 PM

vladislavbelov requested review of this revision.Oct 12 2023, 11:01 PM

wowgetoffyourcellphone awarded a token.Oct 14 2023, 12:50 AM

wraitii accepted this revision.Oct 20 2023, 3:52 PM

This revision is now accepted and ready to land.Oct 20 2023, 3:52 PM

This revision was landed with ongoing or failed builds.Oct 20 2023, 11:45 PM

Closed by commit rP27893: Reverts rP27695 as it breaks LOS update. Fixes #6844 (authored by vladislavbelov). · Explain Why

This revision was automatically updated to reflect the committed changes.

vladislavbelov added a commit: rP27893: Reverts rP27695 as it breaks LOS update. Fixes #6844.

Owners added a subscriber: Restricted Owners Package.Oct 20 2023, 11:45 PM

Revision Contents
Changeset List

Path

Size

source/

simulation2/

components/

CCmpPosition.cpp

3 lines

Diff 22410

View Options

source/simulation2/components/CCmpPosition.cpp

Reverts rP27695 as it breaks LOS updateClosedPublicActions