Page MenuHomeWildfire Games
Differential D5257

Fixes water foam texture size after scale
Needs ReviewPublic
Actions

Authored by vladislavbelov on Tue, Apr 9, 8:11 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Refs rP28010.

Test Plan
  1. Apply the patch and compile the game
  2. Run the game with enabled water effects
  3. Scroll the scale from 50% to 200%

Diff Detail

Event Timeline

vladislavbelov created this revision.Tue, Apr 9, 8:11 PM
vladislavbelov updated this revision to Diff 22857.Tue, Apr 9, 8:14 PM
gameboy added a subscriber: gameboy.Wed, Apr 10, 10:26 AM

@vladislavbelov Thank you very much for providing the patch, which solved this problem.

vladislavbelov published this revision for review.Wed, Apr 10, 10:42 AM
Stan added a subscriber: Stan.Wed, Apr 10, 2:30 PM

Any reason the renderer and the postproc manager would have different sizes ?

vladislavbelov added a comment.Wed, Apr 10, 8:02 PM
In D5257#223695, @Stan wrote:

Any reason the renderer and the postproc manager would have different sizes ?

Yeah, because we have multiple render targets with different resolutions depending on a pass: window resolution (UI and post effects), scene resolution (scaled by postprocmanager), reflection/refraction resolution, shadow map resolution.

Stan added a comment.Fri, Apr 12, 6:11 PM

Ah makes sense.

phosit added a subscriber: phosit.Fri, Apr 12, 7:20 PM
phosit added inline comments.
source/renderer/TerrainRenderer.cpp
614

Why did you remove the static_casts?

Revision Contents
Changeset List

PathSize
source/
renderer/
2 lines
8 lines
13 lines

Diff 22857

View Options

source/renderer/PostprocManager.h

Loading...
View Options

source/renderer/TerrainRenderer.cpp

Loading...
View Options

source/renderer/WaterManager.cpp

Loading...
Wildfire Games · Phabricator