Page MenuHomeWildfire Games
Differential D5274

Make messageBox return a promise
Needs ReviewPublic
Actions

Authored by phosit on Wed, May 29, 5:51 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Split from D5271

Ofthen the messageBox is only used for confirmation like: "Do you really want to overwrite the savegame?"
For example with this patch the code paths of "overwrite savegame" and "make new savegame" can be combined.

In some cases there is nothing done when one button is pressed. That is changed to an early return.

Test Plan

Test different messageBoxes.

Diff Detail

Event Timeline

phosit created this revision.Wed, May 29, 5:51 PM
Vulcan added a comment.Wed, May 29, 5:52 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/9447/display/redirect

phosit added a parent revision: D3807: Get a promise when starting a GUIpage.Wed, May 29, 5:52 PM
phosit added a child revision: D5271: [POC] Remove Engine.PopGuiPage.
Vulcan added a comment.Wed, May 29, 5:53 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/7778/display/redirect

phosit added a comment.Wed, May 29, 5:57 PM

The credentieals is a good example what this diff tries to achieve.
Removing replays too, but more complex.

phosit published this revision for review.Wed, May 29, 6:42 PM
phosit added a child revision: D5275: Implement a MultiPromise and use it.Wed, May 29, 6:59 PM
phosit removed a child revision: D5271: [POC] Remove Engine.PopGuiPage.

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
mod/
gui/
common/
26 lines
modio/
81 lines
public/
gui/
campaigns/
load_modal/
17 lines
hotkeys/
32 lines
loadgame/
18 lines
9 lines
29 lines
lobby/
LobbyPage/
Buttons/
46 lines
19 lines
options/
81 lines
pregame/
32 lines
prelobby/
common/
credentials/
22 lines
replaymenu/
52 lines

Diff 23001

View Options

binaries/data/mods/mod/gui/common/functions_msgbox.js

Loading...
View Options

binaries/data/mods/mod/gui/modio/modio.js

Loading...
View Options

binaries/data/mods/public/gui/campaigns/load_modal/LoadModal.js

Loading...
View Options

binaries/data/mods/public/gui/hotkeys/HotkeysPage.js

Loading...
View Options

binaries/data/mods/public/gui/loadgame/SavegameDeleter.js

Loading...
View Options

binaries/data/mods/public/gui/loadgame/SavegameLoader.js

Loading...
View Options

binaries/data/mods/public/gui/loadgame/SavegameWriter.js

Loading...
View Options

binaries/data/mods/public/gui/lobby/LobbyPage/Buttons/JoinButton.js

Loading...
View Options

binaries/data/mods/public/gui/lobby/LobbyPage/ConnectionHandler.js

Loading...
View Options

binaries/data/mods/public/gui/options/options.js

Loading...
View Options

binaries/data/mods/public/gui/pregame/MainMenuItems.js

Loading...
View Options

binaries/data/mods/public/gui/prelobby/common/credentials/credentials.js

Loading...
View Options

binaries/data/mods/public/gui/replaymenu/replay_actions.js

Loading...
Wildfire Games · Phabricator