Differential D603

Improve strings from rP19652
ClosedPublic
Actions

Authored by Itms on Jun 4 2017, 10:32 PM.

Details

Reviewers

elexis

Commits

rP19735: Improve the strings from r19652.

Summary

Addresses @scythetwirler's concerns about rP19652.

Test Plan

N/A

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Jun 4 2017, 10:32 PM

In D583 causative mentioned that we shouldn't add half sentences. Should this one become a complete sentence too?

I don't know, "Disabled" is not a sentence either. We could go with "Enabled, only if the map comes with treasures of course", but that makes the user sound stupid :)

The only wrong part of the previous string I can identitfy is that the map doesn't place it (it's the map script or map author that placed the treasure).
The new string works for me, but I don't know if it fixes the specific thing is that scythetwirler found awkward.

Executing section Default...
Executing section Source...
Executing section JS...

binaries/data/mods/public/gui/common/gamedescription.js
| 396| »   »   "label":·"[color=\""·+·g_DescriptionHighlight·+·"\"]"·+·title.label·+·":"·+·"[/color]",
|    | [NORMAL] ESLintBear (no-useless-concat):
|    | Unexpected string concatenation of literals.

binaries/data/mods/public/gui/common/gamedescription.js
|  89| »   »   if·(playerData·==·null·||·playerData.Civ·&&·playerData.Civ·==·"gaia")
|    | [NORMAL] JSHintBear:
|    | Use '===' to compare with 'null'.

binaries/data/mods/public/gui/common/gamedescription.js
|  94| »   »   let·isAI·=·playerData.AI·&&·playerData.AI·!=·"";
|    | [NORMAL] JSHintBear:
|    | Use '!==' to compare with ''.

binaries/data/mods/public/gui/common/gamedescription.js
| 311| »   »   »   »   g_GameAttributes.settings.Ceasefire·==·0·?
|    | [NORMAL] JSHintBear:
|    | Use '===' to compare with '0'.
Executing section XML GUI...
Executing section Python...
Executing section Perl...

http://jw:8080/job/phabricator_lint/131/ for more details.

Closed by commit rP19735: Improve the strings from r19652. (authored by Itms). · Explain WhyJun 4 2017, 11:47 PM

This revision was automatically updated to reflect the committed changes.

Build has FAILED

Link to build: http://jw:8080/job/phabricator/1481/
See console output for more information: http://jw:8080/job/phabricator/1481/console

Harbormaster failed remote builds in B2169: Diff 2433!Jun 5 2017, 3:44 AM