Diffusion 0 A.D. Public Repository rP19652

Fix typo that prevented the Disable Treasures label of the objectives dialog…
AuditedrP19652
Actions

Description

Fix typo that prevented the Disable Treasures label of the objectives dialog from showing the correct value.
Remove the double negation "Disable Treasure: Disabled".

Differential Revision: https://code.wildfiregames.com/D523
String accepted by: Sandarac

Details

Auditors

scythetwirler

Committed

elexis

May 24 2017, 6:53 PM

Differential Revision

D523: Fix objectives dialog value of the Disable Treasures setting and remove double negative

Parents

rP19651: Allow opening of the developer overlay in replay mode following rP19558.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 1948
Build 3108: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP19652: Fix typo that prevented the Disable Treasures label of the objectives dialog….May 24 2017, 6:53 PM

scythetwirler raised a concern with this commit.May 24 2017, 6:59 PM

scythetwirler added a subscriber: scythetwirler.

scythetwirler added inline comments.

/ps/trunk/binaries/data/mods/public/gui/common/gamedescription.js
376	Sounds kinda awkward. Maybe "As defined by map" or "Map Default".

This commit now has outstanding concerns.May 24 2017, 6:59 PM

scythetwirler added inline comments.May 24 2017, 7:00 PM

/ps/trunk/binaries/data/mods/public/gui/common/gamedescription.js
373	Treasure(s) plural?

Harbormaster completed building B1948: rP19652: Fix typo that prevented the Disable Treasures label of the objectives dialog….May 24 2017, 9:24 PM

Itms mentioned this in D603: Improve strings from rP19652.Jun 4 2017, 10:32 PM

Addressed by r19735.

All concerns with this commit have now been addressed.Jun 4 2017, 11:49 PM

elexis mentioned this in D1532: Reword the tooltip of the Disable Treasures option.May 28 2018, 12:03 AM

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

common/

gamedescription.js

rP19652

View Options

ps/trunk/binaries/data/mods/public/gui/common/gamedescription.js