test_load is disabled by default (it's verbose and perhaps it's a bit long).
But currently the test doesn't work.
As it's disabled, it's often forgotten I guess.
As suggested by @Sandarac, we need to take care of mods/mod.
The other part of Sandarac's patch are not relevant anymore since @leper commited rP20246.
Details
Details
- Reviewers
elexis - Commits
- rP20326: Fix a disabled template manager test.
- Trac Tickets
- #4522
-
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jenkins-master:8080/job/phabricator/2133/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI...
http://jenkins-master:8080/job/phabricator_lint/604/ for more details.
Comment Actions
Build is green
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jenkins-master:8080/job/phabricator/2134/ for more details.
Comment Actions
Executing section Default... Executing section Source... Executing section JS... Executing section XML GUI...
http://jenkins-master:8080/job/phabricator_lint/605/ for more details.
Comment Actions
(one can also nuke it, or make it all mod compatible)
(enabling it by default and only displaying error is also an option but it could be bad for other mods)
Comment Actions
Can confirm that test_load_all spams the error reported in that ticket, if _DISABLED is removed from the function name and that the provided patch fixes the issue.
| source/simulation2/tests/test_CmpTemplateManager.h | ||
|---|---|---|
| 253 ↗ | (On Diff #3912) | Can we remove this line and enable the test? Doesn't throw errors on my end, so if that is committed too I wouldn't complain. |
| source/simulation2/tests/test_CmpTemplateManager.h | ||
|---|---|---|
| 253 ↗ | (On Diff #3912) | I'd prefer let someone else do it (even if the temptation is big) as I don't know if it's good to launch that test with mods (I should know but I am lazy). |