It allows to Atlas user to not resize the sidebar and bottombar on each Atlas run.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP23424: Saves sidebar/bottombar width/height between Atlas sessions
- Apply the patch and compile the game
- Open Atlas and change size of side bar
- Close Atlas
- Open Atlas and make sure that the size was changed
- Maximize the Atlas window and resize the sidebar as bigger as possible
- Reopen Atlas and make sure that the size was changed but not overflow the window
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 10887 Build 19080: Vulcan Build Jenkins Build 19079: Vulcan Build (macOS) Jenkins Build 19078: Vulcan Build (Windows) Jenkins
Event Timeline
| source/tools/atlas/AtlasUI/CustomControls/SnapSplitterWindow/SnapSplitterWindow.cpp | ||
|---|---|---|
| 22 | <> ? | |
| 71 | Helper function? | |
| source/tools/atlas/AtlasUI/CustomControls/SnapSplitterWindow/SnapSplitterWindow.h | ||
| 41 | m_SashPositionChanged? | |
| source/tools/atlas/AtlasUI/ScenarioEditor/SectionLayout.cpp | ||
| 32–33 | <> ? | |
| source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Cinema/Cinema.cpp | ||
| 24 ↗ | (On Diff #11110) | Split? |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/AtlasUI/CustomControls/SnapSplitterWindow/SnapSplitterWindow.h | 20| class·SnapSplitterWindow·:·public·wxSplitterWindow | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classSnapSplitterWindow:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/AtlasUI/ScenarioEditor/SectionLayout.cpp | 64| BEGIN_EVENT_TABLE(SidebarButton,·wxBitmapButton) | | [MAJOR] CPPCheckBear (unknownMacro): | | There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1612/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/AtlasUI/CustomControls/SnapSplitterWindow/SnapSplitterWindow.h | 20| class·SnapSplitterWindow·:·public·wxSplitterWindow | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classSnapSplitterWindow:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/AtlasUI/ScenarioEditor/SectionLayout.cpp | 64| BEGIN_EVENT_TABLE(SidebarButton,·wxBitmapButton) | | [MAJOR] CPPCheckBear (unknownMacro): | | There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1613/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/tools/atlas/AtlasUI/CustomControls/SnapSplitterWindow/SnapSplitterWindow.h | 20| class·SnapSplitterWindow·:·public·wxSplitterWindow | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classSnapSplitterWindow:' is invalid C code. Use --std or --language to configure the language. source/tools/atlas/AtlasUI/ScenarioEditor/SectionLayout.cpp | 64| BEGIN_EVENT_TABLE(SidebarButton,·wxBitmapButton) | | [MAJOR] CPPCheckBear (unknownMacro): | | There is an unknown macro here somewhere. Configuration is required. If BEGIN_EVENT_TABLE is a macro then please configure it. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1614/display/redirect
Comment Actions
Patch works as expected, though it triggers a compilation warning see inline. (Missing WxUnused)
| source/tools/atlas/AtlasUI/CustomControls/SnapSplitterWindow/SnapSplitterWindow.cpp | ||
|---|---|---|
| 87 | ..\..\..\source\tools\atlas\AtlasUI\CustomControls\SnapSplitterWindow\SnapSplitterWindow.cpp(87): warning C4100: 'evt': unreferenced formal parameter | |
Comment Actions
Thanks, I've tried it (on Fedora 31 with Gnome desktop), and it works as described in the summary and test plan.