Doesn't differentiate between players and observers, make it do.
Details
Details
- Reviewers
Silier - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP25851: Fix game setup lobby player stats stanza.
Test it
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I saw it once in the lobby, it worked on your game you hosted, but when I apply the patch with Arcanist I get this error message:
patching file binaries/data/mods/public/gui/gamesetup/Controllers/LobbyGameRegistration.js Hunk #1 FAILED at 126. 1 out of 1 hunk FAILED -- saving rejects to file binaries/data/mods/public/gui/gamesetup/Controllers/LobbyGameRegistration.js.rej WARNING Some hunks could not be applied cleanly by the unix 'patch' utility. Your working copy may be different from the revision's base, or you may be in the wrong subdirectory. You can export the raw patch file using 'arc export --unified', and then try to apply it by fiddling with options to 'patch' (particularly, -p), or manually. The output above, from 'patch', may be helpful in figuring out what went wrong. picus@Picus 0ad %
Applying it manual to my working copy does not list observers. I also tested it with A25 + latest autociv from github, it does not work.
Comment Actions
Well given the patch's length, I'd say apply it manually ^^
If the patch doesn't apply it could be that it's already applied, could also be because you didn't add context to it, or because Langbart has local changes.
Comment Actions
(Patch error was probably due to line-endings (at least that is what my CLI tells me).)