I suggest key "Alt+O" to toggle
Details
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
binaries/data/config/default.cfg | ||
---|---|---|
152 | indentation Notice that the "O" hotkey will not work in lobby, mp gamesetup etc. (due to chat) So is "Alt+O" still free? | |
binaries/data/mods/public/gui/common/global.js | ||
1 ↗ | (On Diff #3223) | don't use let for globals => var, also g_OptionsPageShown would be better imo |
5 ↗ | (On Diff #3223) | could you explain the g_ViewedPlayer check? (I don't get why it is required) |
binaries/data/mods/public/gui/options/options.js | ||
403 | multiple statements should be spread over different lines | |
binaries/data/mods/public/gui/options/options.xml | ||
13–15 ↗ | (On Diff #3223) | was wondering if it would be useful to add a force save close hotkey (kinda how we have for unit deletes, use same modifier as that, don't know if that hotkey can become a global) |
Idk if the new globals.js file is needed, there isn't another file where this function can be placed?
binaries/data/config/default.cfg | ||
---|---|---|
152 | dialog -> window | |
binaries/data/mods/public/gui/common/global.js | ||
1 ↗ | (On Diff #4231) | Option in plural? |
binaries/data/mods/public/gui/options/options.js | ||
379 | Close without save and Save and Close better? |
binaries/data/mods/public/gui/options/options.js | ||
---|---|---|
379 | "Keep temporary and close" and "Save and close"? Because it keeps the setted option while game is running until exit. |
not true i find functions_global_object.js but this is file is not generaly globaly included. so it may not be made for this purpose. so i just made an js file according to the global.xml file which is overall included (in pages).
binaries/data/mods/public/gui/common/global.js | ||
---|---|---|
7 ↗ | (On Diff #4266) | Not a fan of adding global files with 7 lines. Can't we just overwrite the hotkey in the options dialog? |
binaries/data/mods/public/gui/common/global.xml | ||
7 | Not needed is it, all GUI pages likely include the common directory? | |
binaries/data/mods/public/gui/page_replaymenu.xml | ||
11 | I think this inclusion is missing independently right? No FPS counter otherwise, right? |
Options available in gamesetup, lobby, mainmenu and ingame as hotkey ALT + O, which doesnt interfere for me with any other hotkey :).
Why limit the hotkey for gamesetup, options, session and mainmenu only? I think adding the hotkey to global.xml would work already, so we end up with even shorter code and less duplication...
Feature and hotkey choice seems nice
binaries/data/mods/public/gui/common/functions_global_object.js | ||
---|---|---|
8 | Identifier whether the Options window is shown | |
binaries/data/mods/public/gui/gamesetup/gamesetup.xml | ||
9 ↗ | (On Diff #4904) | semicolon |
binaries/data/mods/public/gui/lobby/lobby.xml | ||
9 ↗ | (On Diff #4904) | same and etc. |
binaries/data/mods/public/gui/manual/intro.txt | ||
52 | period | |
binaries/data/mods/public/gui/options/options.js | ||
392–397 | a save and close thing is good but the "no" should be kept too, (It could be more clear to the user what the save button actually does, but out of scope I guess) |
Yea true. I feel it's rather strange having options gui opened, when hitting hotkey, when in replay menu f.e. or when in structure tree or in history ui. Feeling best, when there is a button for options anyway, where it can be opened.
This is in gamesetup, lobby, mainmenu and ingame. : )
This hotkey could also be accidently hitted. : )
binaries/data/config/default.cfg | ||
---|---|---|
153–154 | L153 is the same hotkey.toggle as before summary.toggle we had named. Actualy this comes from console.toggle L162. So hotkey.toggle name is ok? | |
binaries/data/mods/public/gui/common/functions_global_object.js | ||
10 | Can the variable be definitioned down right before the function? Or must it be here in head. : ) |