This patch deprecates the unnecessary Mechanical class.
The Mechanical visible class is not particularly useful: it is basically the union of Siege and Ship classes. Mechanical is only used in four auras, one of which is corrected to Siege, as it should be, the other three replace it with "Siege", "Ship".
Furthermore, the mechanical_ part was removed from template file names in D1760/rP22204.
Details
- Reviewers
wraitii - Commits
- rP22810: Remove Mechanical class in favour or using Siege and Ship.
Check for mistakes.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/435/display/redirect
Seems good, Mechanical was only useful as "not organic", but we also can write '!Organic'.
binaries/data/mods/public/simulation/components/Identity.js | ||
---|---|---|
68 ↗ | (On Diff #9414) | Is having such a list really useful? |
binaries/data/mods/public/simulation/data/auras/units/heroes/gaul_hero_brennus.json | ||
4 ↗ | (On Diff #9414) | From the description, shouldn't this also apply to structures? |
binaries/data/mods/public/simulation/components/Identity.js | ||
---|---|---|
68 ↗ | (On Diff #9414) | Don't ask me. @fatherbushido reminded me somewhere in the past that this list should be updated, though. |
binaries/data/mods/public/simulation/data/auras/units/heroes/gaul_hero_brennus.json | ||
4 ↗ | (On Diff #9414) | Yeah, I wondered about that too. But wouldn't that be a gameplay change? |
binaries/data/mods/public/simulation/data/auras/units/catafalques/mace_catafalque.json | ||
---|---|---|
3 ↗ | (On Diff #9414) | ["Unit", "Structure"] is actually shorter, but I suppose animals should not be included. |
binaries/data/mods/public/simulation/data/auras/units/heroes/gaul_hero_brennus.json | ||
---|---|---|
4 ↗ | (On Diff #9414) | Yeah I suppose it would. I guess it might be fairer to change the description. |
binaries/data/mods/public/simulation/components/Identity.js | ||
---|---|---|
68 ↗ | (On Diff #9414) | I don't see that this is wrapped in <example>, so it's not arbitrary. |
binaries/data/mods/public/simulation/components/Identity.js | ||
---|---|---|
68 ↗ | (On Diff #9414) | This sounds vaguely like it should be updated to be a Choice then, but that definitely breaks all mods. |