Differential D2326

Fix projectiles fired from sky / missing cast in Vector3D in rP22184
ClosedPublic
Actions

Authored by Stan on Sep 24 2019, 3:40 PM.

Details

Reviewers

wraitii

Commits

rP22990: Fix projectiles fired from sky / missing cast in Vector3D in rP22184. Removes a…

Trac Tickets

#5601

Summary

Projectiles are sometimes fired from the sky following rP22184 / D1171, see https://trac.wildfiregames.com/ticket/5601#comment:4

Test Plan

Test that you see no more flying arrows.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 9593
Build 16058: Vulcan Build	Jenkins
Build 16057: Vulcan Build (Windows)	Jenkins

Event Timeline

Stan created this revision.Sep 24 2019, 3:40 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/827/display/redirect

Harbormaster failed remote builds in B9592: Diff 9954!Sep 24 2019, 3:40 PM

Stan mentioned this in rP22184: Move more things in the projectile part of the Attack/Ranged component.Sep 24 2019, 3:40 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/312/display/redirect

Stan updated this revision to Diff 9955.Sep 24 2019, 3:53 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/828/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/313/display/redirect

Harbormaster completed remote builds in B9593: Diff 9955.Sep 24 2019, 4:03 PM

elexis edited the summary of this revision. (Show Details)Sep 24 2019, 4:09 PM

elexis retitled this revision from Fix missing cast in rP22184 to Fix projectiles fired from sky / missing cast in Vector3D in rP22184.

elexis edited the summary of this revision. (Show Details)

Thanks for looking at this, indeed that's broken.

This revision is now accepted and ready to land.Sep 24 2019, 4:17 PM

Closed by commit rP22990: Fix projectiles fired from sky / missing cast in Vector3D in rP22184. Removes a… (authored by Stan). · Explain WhySep 24 2019, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Stan added a commit: rP22990: Fix projectiles fired from sky / missing cast in Vector3D in rP22184. Removes a….

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

simulation/

components/

	Attack.js
	Attack.js (revision 22989)

2 lines

Diff 9955

View Options

binaries/data/mods/public/simulation/components/Attack.js

Fix projectiles fired from sky / missing cast in Vector3D in rP22184ClosedPublicActions