Page MenuHomeWildfire Games
Feed Advanced Search

Jul 28 2022

Mercury updated the diff for D4718: Allocator and generator for component data..

More specific names and types, use for_each in CComponentDataHolder::ResetState.

Jul 28 2022, 3:16 AM

Jul 26 2022

Mercury updated the diff for D4718: Allocator and generator for component data..

Changed the data type of SComponentDataGenerator::m_LastIndex from bool to uint_32,

Jul 26 2022, 8:14 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Previous upload was a mistake, this one is better hopefully.

Jul 26 2022, 1:12 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Allocator is now able to expand to arbitrary capacity.

Jul 26 2022, 12:10 AM

Jul 6 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jul 6 2022, 5:43 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Formated some comments.

Jul 6 2022, 5:43 AM

Jul 5 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jul 5 2022, 9:37 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

reworked CGame::IsGameFinished, mostly changed it back to it was before. Seems like a dependency injection issue.

Jul 5 2022, 8:06 AM
Mercury added inline comments to D4718: Allocator and generator for component data..
Jul 5 2022, 6:00 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Simplified CGame::IsGameFinished

Jul 5 2022, 6:00 AM

Jul 4 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jul 4 2022, 7:42 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

exclude graph2.*

Jul 4 2022, 2:45 AM
Mercury added inline comments to D4718: Allocator and generator for component data..
Jul 4 2022, 1:55 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

included tests.

Jul 4 2022, 1:30 AM

Jul 3 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jul 3 2022, 11:37 PM
Mercury updated the diff for D4718: Allocator and generator for component data..

Added a test file.
Standardized instance of SComponentDataGenerator names to 'gen'.
Renamed some instances of the ordered list given by GetComponentsByInterface from ents to comps.
Changed ComponentType.dealloc to ComponentType.destruct.
Changed type name of ComponentType.dealloc from DeallocFunc to DestructFunc.

Jul 3 2022, 11:32 PM

Jul 2 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jul 2 2022, 12:22 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Renamed GetEntitiesWithInterface to GetComponentsByInterface and GetEntitiesWithInterfaceUnordered to GetComponentsByInterfaceUnordered.

Jul 2 2022, 12:20 AM

Jun 30 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jun 30 2022, 5:33 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Fixed broken upload from yesterday. Sorry.

Jun 30 2022, 4:53 AM

Jun 29 2022

Mercury updated the diff for D4718: Allocator and generator for component data..

std::byte* instead of void*. Explicit keyword on SComponentDataGenerator constructor.

Jun 29 2022, 6:04 AM

Jun 28 2022

Mercury added a comment to D4718: Allocator and generator for component data..

I haven't tested multiplayer or rejoin, Ill have to dig up my old laptop.

Jun 28 2022, 1:43 AM

Jun 27 2022

Mercury added a comment to D4718: Allocator and generator for component data..

On Combat Demo Huge I see a 4% improvement vs. main. This is kinda a worst case scenario for this code since we have a single peak that trails off rather then the multiple peaks and valleys pattern it was written for.

Jun 27 2022, 11:47 PM
Mercury updated the diff for D4718: Allocator and generator for component data..

Added spaces after where and for.

Jun 27 2022, 1:27 AM
Mercury added a comment to D4719: graph2.html and graph2.js.

Ah, ok! Ill implement the average and total code inside prolfile2 instead then.

Jun 27 2022, 12:48 AM
Mercury added a comment to D4719: graph2.html and graph2.js.

Profile2 as i understand it is for seeing the performance of a running game in real time. This is an alternative to graph.html and graph.js as used in simulation replay mode.

Jun 27 2022, 12:16 AM

Jun 26 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jun 26 2022, 11:36 PM

Jun 25 2022

Mercury updated the summary of D4719: graph2.html and graph2.js.
Jun 25 2022, 10:01 AM
Mercury added inline comments to D4718: Allocator and generator for component data..
Jun 25 2022, 9:56 AM
Mercury updated the diff for D4718: Allocator and generator for component data..

Moved CComponentDataHolder and SComponentDataGenerator from heap to stack. Added alignment.

Jun 25 2022, 9:44 AM

Jun 22 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jun 22 2022, 2:24 AM

Jun 21 2022

Mercury added inline comments to D4718: Allocator and generator for component data..
Jun 21 2022, 10:43 PM
Mercury added inline comments to D4718: Allocator and generator for component data..
Jun 21 2022, 9:32 PM
Mercury updated the diff for D4718: Allocator and generator for component data..

Indentation, voidptr

Jun 21 2022, 9:04 PM
Mercury requested review of D4718: Allocator and generator for component data..
Jun 21 2022, 4:11 AM
Mercury requested review of D4719: graph2.html and graph2.js.
Jun 21 2022, 1:07 AM

May 13 2022

Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

formatting whitespace, change some let to const.

May 13 2022, 7:58 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Default arguments for EjectOrKill, removed VIM from .gitignore

May 13 2022, 7:15 AM

May 12 2022

Mercury added inline comments to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
May 12 2022, 7:07 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

generated with git diff -U9999 instead of git diff --no-prefix -U9999

May 12 2022, 7:46 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

I don't know what Vulcan is trying to tell me here.

May 12 2022, 7:41 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Diff has context now.

May 12 2022, 7:30 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

renamed attacker and attackerOwner parameters to changeSource and changeSourceOwner in Health.RegisterHealthChanged and throughout GarisonHolder.

May 12 2022, 7:29 AM

May 11 2022

Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Potential optimization to the event listener?

May 11 2022, 9:11 PM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

git diff --no-prefix -U9999

May 11 2022, 8:40 PM

May 10 2022

Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Ok, thanks for the help :)

May 10 2022, 12:47 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

style conformity changes, no semantic change.

May 10 2022, 12:39 PM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Remove DamageTaken, add attacker and attackerOwner to HealthChanged

May 10 2022, 12:14 PM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

HealthChanged is fired in RegisterHealthChanged
RegisterHealthChanged is called in Reduce
Reduce is called in TakeDamage
TakeDamage has attacker

May 10 2022, 11:35 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Another issue with storing which entity they died trying to get out of is that the entity might not be destroyed at that moment.

May 10 2022, 10:58 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@wraitii Storing in the stats tracker and integrating at the end sounds ok. It won't assign loot.

May 10 2022, 10:01 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

oh wait, the last line of
void CComponentManager::PostMessage(entity_id_t ent, const CMessage& msg)
is
SendGlobalMessage(ent, msg);

May 10 2022, 9:18 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

Looking at source/simulation2/system/ComponentManager.cpp line 974 it seems to be saying that when you provide an entity to PostMessage only the components of that entity will be notified.

May 10 2022, 9:11 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan would something like

May 10 2022, 9:01 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

@Stan Is that true when the event is targeting a single entity as well?

May 10 2022, 8:55 AM
Mercury added a comment to D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

I put some time into thinking about how to do this without a message but didn't come up with anything better. JS event emitters are generally kinda cheap I thought? Just a hash table lookup with a JIT symbol and a run through an array of callbacks. Should cost almost nothing if there are no listeners. O(1)?

May 10 2022, 8:44 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

included previously unincluded files

May 10 2022, 7:56 AM
Mercury updated the diff for D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.

fixing which files are included hopefully

May 10 2022, 7:37 AM
Mercury requested review of D4643: Assign credit for units killed by cmpGarisonHolder.EjectOrKill.
May 10 2022, 7:34 AM