Page MenuHomeWildfire Games

fabio (Fabio Pedretti)
User

Projects

User Details

User Since
Dec 30 2016, 10:52 PM (146 w, 4 h)

Recent Activity

Sep 2 2019

fabio added a comment to D1931: Refactor HWDetect and rendering options fully.

Reference to S3TC may as well mostly removed altogether, just quit with an error if not detected. See https://trac.wildfiregames.com/ticket/4803

Sep 2 2019, 12:56 PM

Apr 21 2019

fabio added a comment to D1691: Remove boost "system" from Mac OS build system..

Ok, so just commit the second hunk?

Apr 21 2019, 10:17 AM
fabio added a comment to D1691: Remove boost "system" from Mac OS build system..

I said system, which got removed from Linux times ago, as I wrote here:
https://trac.wildfiregames.com/ticket/4362#comment:26
And which is removed in the second hunk of the patch.

Apr 21 2019, 7:49 AM

Apr 20 2019

fabio added a comment to D1691: Remove boost "system" from Mac OS build system..

Why not? system was already removed from Linux since it is no longer used, OS X should follow...

Apr 20 2019, 5:57 PM

Jan 28 2019

fabio accepted D1691: Remove boost "system" from Mac OS build system..
Jan 28 2019, 1:23 PM

Jan 8 2019

fabio added a comment to D1691: Remove boost "system" from Mac OS build system..

Looks Good To Me
:)

Jan 8 2019, 2:10 PM
fabio accepted D1691: Remove boost "system" from Mac OS build system..

Untested, but LGTM.

Jan 8 2019, 1:25 PM

Jan 7 2019

fabio added inline comments to D1691: Remove boost "system" from Mac OS build system..
Jan 7 2019, 4:02 PM

Dec 9 2018

fabio accepted D1691: Remove boost "system" from Mac OS build system..
Dec 9 2018, 4:58 PM

May 16 2018

fabio added a comment to D86: Cleanup of hwdetect.js and its test..

Some comments.

May 16 2018, 3:03 PM
fabio added inline comments to D1486: Graphics Improvements.
May 16 2018, 2:22 PM
fabio added a comment to D1486: Graphics Improvements.

D86 also has some cleanups for hwdetect.js that are related and worth checking.

May 16 2018, 11:16 AM
fabio added a comment to D1486: Graphics Improvements.

You should also have a look at this file, where some options are dynamically enabled based on detected hardware:
https://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/mod/hwdetect/hwdetect.js

May 16 2018, 11:11 AM

Mar 18 2018

fabio committed rP21583: Update some OS X libraries with security fixes and hopefully low regression….
Update some OS X libraries with security fixes and hopefully low regression…
Mar 18 2018, 6:21 PM

Jan 2 2018

fabio added a comment to D1097: Add a 8-bit music Easter Egg.

Committed the 32 kbps version. We may use higher bitrates for the standard musics.

Jan 2 2018, 4:33 PM
fabio committed rP20751: Add 8-bit easteregg music track..
Add 8-bit easteregg music track.
Jan 2 2018, 4:28 PM
fabio added a comment to D1097: Add a 8-bit music Easter Egg.

Here are 3 versions of the wav coded with aotuv at quality 0 (64kb/s) ,-1 (48kb/s) and -2 (32 kb/s).
Feel free to try them, if the 64 kb/s is not enough I can try with a higher setting.

Jan 2 2018, 11:50 AM

Dec 30 2017

fabio added a comment to D1097: Add a 8-bit music Easter Egg.

I am away now, I can do the encoding tomorrow, I suppose.

Dec 30 2017, 6:05 PM

Dec 4 2017

fabio added a comment to D1097: Add a 8-bit music Easter Egg.

Try:
ldd /usr/bin/oggenc
to check if oggenc links to newer libvorbis.

Dec 4 2017, 8:36 PM

Dec 3 2017

fabio added a comment to D1097: Add a 8-bit music Easter Egg.
In D1097#43717, @elexis wrote:

I have tried oggenc with the quality parameter only.
For quality 0 I get a nominal bitrate of 64kbps. I believe to hear a difference at 25 seconds.
For quality 4 128kbps, quality 6 192kbps.
Maybe ogg is much smarter than mp3, but when listening to mp3s I'm really dissatisfied with 192kbps. Indeed people should hear the music on youtube or download it if they really want to however.
Since this is an 8bit track and only an easteregg we can justify reducing the quality and have a diffeent bitrate for this file to save that MB.

Dec 3 2017, 5:17 PM
fabio added a comment to D1097: Add a 8-bit music Easter Egg.

Also the fixed rate is inefficient, and intended for fixed size channels, e.g. ISDN were you can't go higher and you don't benefits from saving during silence, we should use vbr instead, uses higher bitrate where needed, save space on easy zones.
IIRC ffmpeg encoder is also broken with vorbis, I suggest using official oggenc on Linux or oggdrop on windows, with aotuv encoder library.

Dec 3 2017, 2:49 PM
fabio added a comment to D1097: Add a 8-bit music Easter Egg.
In D1097#43524, @elexis wrote:

The phrase play-custom-tracks is slightly misleading, because the tracks itself aren't custom. I'd say play-tracks should be sufficient and the custom part is only needed in music.js.
I suggest that we use the parameter argument, so that the player can type retro me to play and retro me 0 to switch back.
We can do this (possibly together with the cleanup mention in the inline comments) in a separate patch, or not at all, or all in this patch if you want.
About the ogg file:
Weird that it starts with 0_, but I won't make it inconsistent with the audio repository.
ogginfo reveals me:

Vendor: Lavf58.2.100
Channels: 2
Rate: 44100
Nominal bitrate: 112,000000 kb/s

mplayer -identify 0_8Bit_Bonus_Track.wav tells me however

ID_AUDIO_BITRATE=2116800
ID_AUDIO_RATE=44100
ID_AUDIO_NCH=2

112kbps is not the best quality. Arguably it doesn't matter for an 8Bit track, still.
The other tracks in that folder are in 160 kbps, so that should be fine for this 8bit track too then for the time being (the other tracks might be nice to have in 320kbps eventually).
I have set a fixed bitrate using ffmpeg and -b:a.

Dec 3 2017, 2:41 PM

Aug 14 2017

fabio added a comment to D745: Add shadow map quality.

Is it just me that I found the low quality with its blurred edges more realistic? Maybe very low it is too much blurred, eventually something between the two extremes.

Aug 14 2017, 10:31 AM

Aug 13 2017

fabio added a comment to D779: JPEG screenshot format option.

No idea if this is possible, but having the compression happens in its own thread would not slowdown the game, either PNG or JPEG.

Aug 13 2017, 1:26 PM

Aug 10 2017

fabio added a comment to D779: JPEG screenshot format option.

I found the JPEG blockiness around text a bit annoying on the main menu screenshot. Obligatory humour image:

Aug 10 2017, 12:14 PM
fabio added a comment to D779: JPEG screenshot format option.

I am not a fan of lossy image compression, jpg also isn't great with non photographic material (e.g. GUI elements).
Also if the screenshot is edited and then resaved again as jpg this introduces a double lossy compression with visible artefacts.

Aug 10 2017, 10:46 AM

Jul 8 2017

fabio added a comment to D718: Upgrade some bundled Windows libraries.

Any idea why enet dlls are so much bigger in size?

Jul 8 2017, 9:00 AM

Jul 2 2017

fabio added inline comments to D683: Update AppData.
Jul 2 2017, 11:05 AM

Jun 27 2017

fabio added a comment to D683: Update AppData.

There is at least a link with http that should be changed to https (the first screenshot one).

Jun 27 2017, 7:12 PM
fabio added a comment to D683: Update AppData.

You may want to update most URLs with https rather than http where available.

Jun 27 2017, 6:13 PM

Jun 17 2017

fabio added a comment to D474: Add axes to CChart.

Jun 17 2017, 8:34 AM