- User Since
- Dec 30 2016, 10:52 PM (195 w, 4 d)
Jul 4 2020
Hi, here are my comments! (Sorry for the delay :) )
Sep 2 2019
Reference to S3TC may as well mostly removed altogether, just quit with an error if not detected. See https://trac.wildfiregames.com/ticket/4803
Apr 21 2019
Ok, so just commit the second hunk?
I said system, which got removed from Linux times ago, as I wrote here:
And which is removed in the second hunk of the patch.
Apr 20 2019
Why not? system was already removed from Linux since it is no longer used, OS X should follow...
Jan 28 2019
Jan 8 2019
Looks Good To Me
Untested, but LGTM.
Jan 7 2019
Dec 9 2018
May 16 2018
D86 also has some cleanups for hwdetect.js that are related and worth checking.
You should also have a look at this file, where some options are dynamically enabled based on detected hardware:
Mar 18 2018
Jan 2 2018
Committed the 32 kbps version. We may use higher bitrates for the standard musics.
Here are 3 versions of the wav coded with aotuv at quality 0 (64kb/s) ,-1 (48kb/s) and -2 (32 kb/s).
Feel free to try them, if the 64 kb/s is not enough I can try with a higher setting.
Dec 30 2017
I am away now, I can do the encoding tomorrow, I suppose.
Dec 4 2017
to check if oggenc links to newer libvorbis.
Dec 3 2017
Also the fixed rate is inefficient, and intended for fixed size channels, e.g. ISDN were you can't go higher and you don't benefits from saving during silence, we should use vbr instead, uses higher bitrate where needed, save space on easy zones.
IIRC ffmpeg encoder is also broken with vorbis, I suggest using official oggenc on Linux or oggdrop on windows, with aotuv encoder library.
Aug 14 2017
Is it just me that I found the low quality with its blurred edges more realistic? Maybe very low it is too much blurred, eventually something between the two extremes.
Aug 13 2017
No idea if this is possible, but having the compression happens in its own thread would not slowdown the game, either PNG or JPEG.
Aug 10 2017
I found the JPEG blockiness around text a bit annoying on the main menu screenshot. Obligatory humour image:
I am not a fan of lossy image compression, jpg also isn't great with non photographic material (e.g. GUI elements).
Also if the screenshot is edited and then resaved again as jpg this introduces a double lossy compression with visible artefacts.
Jul 8 2017
Any idea why enet dlls are so much bigger in size?
Jul 2 2017
Jun 27 2017
There is at least a link with http that should be changed to https (the first screenshot one).
You may want to update most URLs with https rather than http where available.