Page MenuHomeWildfire Games

gentz (Hal Gentz)
User

Projects

User Details

User Since
Oct 8 2017, 1:59 AM (66 w, 6 d)

Recent Activity

Fri, Jan 4

gentz updated the diff for D1717: Fix Olist text wrapping.
Fri, Jan 4, 2:06 AM

Thu, Jan 3

elexis awarded D1717: Fix Olist text wrapping a Like token.
Thu, Jan 3, 5:39 PM
gentz added a comment to D1723: [WIP] Replay Database.
In D1723#68498, @gentz wrote:

Yes, but you will need to login to upload/vote on/comment on/report replays, so might as well have them log in.

Should it be a requirement - to login?

Well, requiring users to login for those actions will help moderators moderate. I guess the alternative would be to remember the IP which did an action, but that doesn't strike me as a good alternative.

Thu, Jan 3, 12:26 AM
gentz added a comment to D1723: [WIP] Replay Database.
In D1723#68506, @elexis wrote:
  • Ideally it should work with the pyrogenesis engine in general, not only with 0ad that uses it. Other pyrogenesis games may use different replay attributes, so it would be more versatile to avoid hardcodings where possible. (Perhaps such a game would have to specify an own set of supported properties that the backend would have to load to support them.)

Yeah, that's a good idea. I'll add it to the todo list.

Thu, Jan 3, 12:22 AM

Wed, Jan 2

gentz added a comment to D1723: [WIP] Replay Database.
In D1723#68484, @gentz wrote:

I was planning to host it myself on an OVH VPN, as I don't imagine it will consume that much space.

I'm not sure that it's possible to store WFG collected data on third party servers.

Wouldn't be this be no different than modio? WFG doesn't host that either, afaik.

Wed, Jan 2, 2:26 PM
gentz updated the diff for D1723: [WIP] Replay Database.

Remove some things.

Wed, Jan 2, 2:12 PM
gentz added a comment to D1723: [WIP] Replay Database.

Before review I have arch-questions:

  • Why boost.asio was used? ModIo uses CURL and actually does the same thing. So I'd prefer to not have different ways for the same goal.
Wed, Jan 2, 12:35 PM
gentz added a comment to D1723: [WIP] Replay Database.
In D1723#68465, @smiley wrote:

(Might want to ask who ever maintains the WFG servers whether this is something that is affordable space wise)

Wed, Jan 2, 11:58 AM
gentz updated the diff for D1723: [WIP] Replay Database.

Some of Stan's suggestions.

Wed, Jan 2, 11:54 AM
gentz added inline comments to D1723: [WIP] Replay Database.
Wed, Jan 2, 11:53 AM
gentz updated the diff for D1723: [WIP] Replay Database.

Prep for the Replay viewer.

Wed, Jan 2, 11:29 AM
gentz updated the diff for D1723: [WIP] Replay Database.

Username querying.

Wed, Jan 2, 8:44 AM
gentz updated the diff for D1723: [WIP] Replay Database.

Fix feedback. Make code more consistent. Add window that opens when replays are pressed on. Add UserDatas parsing code.

Wed, Jan 2, 7:06 AM

Tue, Jan 1

gentz updated the diff for D1723: [WIP] Replay Database.

Add submission date column and fix scrollbar.

Tue, Jan 1, 2:30 PM
gentz updated the diff for D1717: Fix Olist text wrapping.
Tue, Jan 1, 11:52 AM
gentz added a comment to D1723: [WIP] Replay Database.
In D1723#68257, @elexis wrote:

Wanna post a description what this feature is about?

Tue, Jan 1, 1:13 AM
gentz updated the diff for D1723: [WIP] Replay Database.
Tue, Jan 1, 12:48 AM
gentz updated the diff for D1717: Fix Olist text wrapping.
Tue, Jan 1, 12:09 AM

Mon, Dec 31

gentz updated the diff for D1717: Fix Olist text wrapping.
Mon, Dec 31, 11:58 PM
gentz added a comment to D1717: Fix Olist text wrapping.
In D1717#68290, @elexis wrote:

One could also make it a COList setting whether or not to use linewrapping. Could even make it a config option for the replay menu, but I'm not sure if it's useful enough (as it costs some user attention time / GUI space).

If linewrapping is enabled (whether forced or not), then one must also consider the possibility for an item producing so much height that the COList becomes unusable.
Perhaps the number of characters per cell could be limited to account for that.
For example the lobby gamelist could contain games whose gamename has practically arbitrary length (ticket somewhere).

Isn't this sort've unrelated to this PR? Linewrapping has always been enabled for the items. It's just that prior to these changes, it would start wrapping too late.

Mon, Dec 31, 11:55 PM
gentz updated the summary of D1723: [WIP] Replay Database.
Mon, Dec 31, 8:45 AM
gentz planned changes to D1723: [WIP] Replay Database.
Mon, Dec 31, 8:42 AM
gentz updated the diff for D1723: [WIP] Replay Database.

I forgot to include CMultilist.{cpp,h}

Mon, Dec 31, 8:42 AM
gentz planned changes to D1723: [WIP] Replay Database.
Mon, Dec 31, 8:40 AM
gentz created D1723: [WIP] Replay Database.
Mon, Dec 31, 8:39 AM
gentz added a comment to D1717: Fix Olist text wrapping.

I didn't find your name in credits (wasn't you added yet): are your credits in the D953 are up to date?

They are up to date.

Mon, Dec 31, 4:22 AM
gentz updated the diff for D1717: Fix Olist text wrapping.
Mon, Dec 31, 3:32 AM
gentz updated the diff for D1717: Fix Olist text wrapping.
Mon, Dec 31, 2:39 AM
gentz added inline comments to D1717: Fix Olist text wrapping.
Mon, Dec 31, 2:38 AM
gentz updated the diff for D1717: Fix Olist text wrapping.
Mon, Dec 31, 1:20 AM
gentz updated the diff for D1717: Fix Olist text wrapping.
Mon, Dec 31, 1:17 AM

Sun, Dec 30

gentz added inline comments to D1717: Fix Olist text wrapping.
Sun, Dec 30, 8:51 PM
gentz updated the diff for D1717: Fix Olist text wrapping.

The context is still unavailable. Also usually a patch needs to be created from the root folder for an easy apply.

I can't add context without dragging in changes I don't want in. Here is it done from root, however.

Sun, Dec 30, 2:34 PM
gentz updated the diff for D1717: Fix Olist text wrapping.
Sun, Dec 30, 2:30 PM
gentz planned changes to D1717: Fix Olist text wrapping.
Sun, Dec 30, 2:22 PM
gentz added a comment to D1717: Fix Olist text wrapping.
In D1717#68027, @elexis wrote:

Not sure about the removal of the headerheight property. I guess the setting is not so important, because noone wants the column header height to be lower than the textsize, nor does anyone reasonably want wasted space there.
But consider that the column sorting sprites also need to be accounted for.

Sun, Dec 30, 2:22 PM
gentz updated the diff for D1717: Fix Olist text wrapping.

And now I have to manually edit the patches... (via svn diff COList.* ../../binaries/data/mods/mod/gui/common/modern/styles.xml ../../binaries/data/mods/mod/gui/gui.* | vipe | arc diff --raw)

Sun, Dec 30, 1:35 PM
gentz updated the diff for D1717: Fix Olist text wrapping.
Sun, Dec 30, 1:27 PM
gentz added a comment to D1717: Fix Olist text wrapping.

I've been doing svn diff COList.cpp | arc diff --raw, because I didin't want to pull in my other changes to the different parts of the code base.

Sun, Dec 30, 1:27 PM
gentz updated the diff for D1717: Fix Olist text wrapping.
Sun, Dec 30, 10:36 AM
Angen awarded D1717: Fix Olist text wrapping a Like token.
Sun, Dec 30, 10:16 AM
gentz updated the diff for D1717: Fix Olist text wrapping.

Accounted for cases where width is absolute. Also made it sow that the header expands to fit the whole text.
https://i.imgur.com/u8M8jKN.png

Sun, Dec 30, 8:30 AM

Sat, Dec 29

gentz added a reviewer for D1717: Fix Olist text wrapping: Restricted Owners Package.
Sat, Dec 29, 10:54 PM
gentz created D1717: Fix Olist text wrapping.
Sat, Dec 29, 10:53 PM

Jan 5 2018

gentz updated the diff for D1195: More detailed what changed messages..

Missed one

Jan 5 2018, 9:47 PM
gentz updated the diff for D1195: More detailed what changed messages..

Translation thingy

Jan 5 2018, 9:45 PM
gentz added inline comments to D1195: More detailed what changed messages..
Jan 5 2018, 9:40 PM
gentz updated the diff for D1195: More detailed what changed messages..

Made it throw an error instead.

Jan 5 2018, 9:38 PM
gentz added inline comments to D1195: More detailed what changed messages..
Jan 5 2018, 9:24 PM
gentz added a comment to D1195: More detailed what changed messages..

@elexis @Imarok What exactly should I change? Do you want me to make it only send the differences across the network?

Jan 5 2018, 9:21 PM
gentz added a comment to D1195: More detailed what changed messages..
In D1195#48465, @elexis wrote:

What does it show if I change every gamesetting while nobody set ready? Only the last setting changed or every setting changed? If it's the first, it seems misleading, if it's the last it seems too spammy, no?

Even when I was not ready I got every change message from more options.

Jan 5 2018, 9:16 PM
gentz updated the diff for D1195: More detailed what changed messages..
Jan 5 2018, 9:09 PM
gentz updated the diff for D1195: More detailed what changed messages..

Fixed these 3 bugs:

  1. 3 random messages the host gets when he starts hosting, how do I get rid of those?
  2. Scrolling too fast makes it cycle between the real message and another message
  3. The first proper message appears twice for some reason
Jan 5 2018, 7:44 PM
ffffffff awarded D1195: More detailed what changed messages. a Like token.
Jan 5 2018, 3:23 PM
gentz updated the summary of D1195: More detailed what changed messages..
Jan 5 2018, 6:06 AM
gentz created D1195: More detailed what changed messages..
Jan 5 2018, 6:00 AM
gentz added a comment to D1027: New UI for gamesetup options.

Maybe have it so that the summary is by default at where the options go right now and then have the options take its position when their tabs are presses? Honestly, I've never actually read the map description cause I've found it easier to glance at the map settings.

Jan 5 2018, 1:37 AM

Jan 4 2018

gentz added a comment to D1027: New UI for gamesetup options.

Can the map description bellow the tab buttons be converted into a tab like the rest of the settings? If you do that then the tabs buttons could be made less wide which I think would make them look better.

Jan 4 2018, 3:10 PM
gentz updated the diff for D1194: Shrinking things in Match Creator to provide more room for other stuff..

IMHO I think D1027 is a better solution for cramming more things in the bottom. I've removed things related to the map options. (A.k.a 90% of this patch)

Jan 4 2018, 3:04 PM
gentz updated the diff for D1194: Shrinking things in Match Creator to provide more room for other stuff..
Jan 4 2018, 2:39 PM
gentz updated the summary of D1194: Shrinking things in Match Creator to provide more room for other stuff..
Jan 4 2018, 6:46 AM
gentz created D1194: Shrinking things in Match Creator to provide more room for other stuff..
Jan 4 2018, 6:38 AM
gentz added a comment to D1153: Optional lobby chat presence brightness and dot, player ratings.

This looks awesome but I've experienced a couple issues:

  1. You get pinged every time you enter the lobby if your name was mentioned in the past. It should only ping once.
  2. Leaving games, or having others start games or others leaving games gives the following error:s
Jan 4 2018, 3:17 AM

Oct 13 2017

gentz added a comment to D953: Add basic Clang 6 support.
In D953#37332, @leper wrote:

Both change set "b70ae970d45d" (Part 1's parent) and change set "336759fb7df0" (Part 9) fail with the linker errors mentioned previously. So it was fixed earlier than that,.

later, not earlier.

My bad.

Oct 13 2017, 11:37 AM

Oct 11 2017

gentz added a comment to D953: Add basic Clang 6 support.

I've started git bisecting the issue, gimme a couple days at most to finish bisecting.

Oct 11 2017, 8:09 AM
gentz added a comment to D953: Add basic Clang 6 support.
In D953#37300, @leper wrote:

Do you still have that git(?) using thing around? If yes, care to test if the fix occured in April 2016? (At least that is when some of the related code changed https://bugzilla.mozilla.org/show_bug.cgi?id=933257.)

Oct 11 2017, 7:48 AM

Oct 10 2017

gentz added a comment to D953: Add basic Clang 6 support.
In D953#37274, @leper wrote:

(and only add one cast if it turns out to be ok).

You'd need both casts, as after you cast the first one, it gives a similar warning for the second.

Oct 10 2017, 4:23 AM
gentz updated the diff for D953: Add basic Clang 6 support.

Fixed small typo

Oct 10 2017, 1:11 AM
gentz added a comment to D953: Add basic Clang 6 support.

Sorry for taking to long to get back on this.

Oct 10 2017, 1:03 AM

Oct 9 2017

gentz added inline comments to D953: Add basic Clang 6 support.
Oct 9 2017, 11:02 PM
gentz updated the diff for D953: Add basic Clang 6 support.

Fixes comments

Oct 9 2017, 11:02 PM
gentz created D953: Add basic Clang 6 support.
Oct 9 2017, 2:09 PM