Page MenuHomeWildfire Games

mammadori (mammadori)
User

Projects

User Details

User Since
Nov 23 2020, 10:03 PM (21 w, 2 d)

Recent Activity

Dec 14 2020

mammadori added a comment to D3213: tools/entity/checkref perl to python.
In D3213#142287, @Stan wrote:

Nice! Will try to test it soon (not tonight as something came up) i think you forgot to remove the entity.pm file :)

Dec 14 2020, 7:06 PM
mammadori updated the diff for D3213: tools/entity/checkref perl to python.

Fixed invoking with -t in windows (also is python, invoke a module)

Dec 14 2020, 6:22 PM
mammadori updated the diff for D3213: tools/entity/checkref perl to python.

Included logging, and the bad separator fix

Dec 14 2020, 5:13 PM
mammadori added inline comments to D3213: tools/entity/checkref perl to python.
Dec 14 2020, 5:10 PM

Dec 13 2020

mammadori added a comment to D3213: tools/entity/checkref perl to python.
In D3213#142105, @Stan wrote:

Also if I may, is it possible to have the prints as the script goes, instead of all when it fails? Maybe this is a windows bug?

Dec 13 2020, 1:39 PM
mammadori updated the diff for D3213: tools/entity/checkref perl to python.

Explicit utf8 opening.

Dec 13 2020, 1:36 PM
mammadori updated the diff for D3213: tools/entity/checkref perl to python.

Changed path handling, added mul_round

Dec 13 2020, 8:23 AM

Dec 11 2020

mammadori updated the diff for D3213: tools/entity/checkref perl to python.

"fixed" path for windows

Dec 11 2020, 11:22 PM
mammadori requested review of D3213: tools/entity/checkref perl to python.
Dec 11 2020, 8:52 PM
mammadori accepted D3201: Fix CxxTest for Python3.

I tried and it works. However it generates 3 warnings, this patch below fixes them.

Dec 11 2020, 9:41 AM

Dec 10 2020

mammadori accepted D3188: Another fix related to moving templates to civ-specific folders..

Tested with nomad on latest svn. It works.

Dec 10 2020, 8:36 AM

Dec 9 2020

mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Fixed Tooltips not working, store just generic, refactored cmpResourceGatherer.AddToPlayerCounter

Dec 9 2020, 6:32 PM

Dec 8 2020

mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Fixed preinc and predec.

Dec 8 2020, 10:48 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Dec 8 2020, 10:47 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Fixed tooltip text.

Dec 8 2020, 10:09 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Addressed latest comments, refreshed screenshot.

Dec 8 2020, 8:52 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Dec 8 2020, 8:17 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Included tooltip (mouseover) support, thanks to @Nescio. Hoping is correct to handle translation like this.

Dec 8 2020, 2:51 PM

Dec 7 2020

mammadori added a comment to D3155: Show Gatherers next to resource icons.

So I've tried your patch. Two things:

  • Only the first digit is in the bottom-right corner of the resource icon, which means if the number is ten or more, the first digit is on the icon, the other right next to it; thus the 4 in 4 is aligned with the 1 in 13 (it ought to be with the 3).
Dec 7 2020, 10:36 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Added more space since we moved right 4 pixels for readability.

Dec 7 2020, 8:37 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Renamed to AddToPlayerCounter, RemoveFromPlayerCounter. Addressed latest comments.

Dec 7 2020, 3:22 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Dec 7 2020, 1:44 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Addressed latest comments.

Dec 7 2020, 1:04 PM
mammadori added a comment to D3188: Another fix related to moving templates to civ-specific folders..

I tried this patch and I confirm it fixes the "nomad" option in my tests.

Dec 7 2020, 12:35 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Addressed latest comments. Cleaned some cruft.

Dec 7 2020, 12:23 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Dec 7 2020, 12:21 PM

Dec 6 2020

mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Removed handling of traders and trickles, just gatherers. Starts counting earlier as gatherers. Addressed some comments, cleaned and refactored.

Dec 6 2020, 7:44 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Dec 6 2020, 7:41 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Cleaned a bit, some renaming, some comments addressed.

Dec 6 2020, 12:44 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Dec 6 2020, 12:20 PM

Dec 5 2020

mammadori updated the summary of D3155: Show Gatherers next to resource icons.
Dec 5 2020, 6:15 PM
mammadori updated the summary of D3155: Show Gatherers next to resource icons.
Dec 5 2020, 6:15 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Seems to work, death supported, some comments addressed.

Dec 5 2020, 1:04 PM

Dec 4 2020

mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Dec 4 2020, 6:32 PM

Dec 1 2020

mammadori added a comment to D3155: Show Gatherers next to resource icons.
In D3155#139549, @Angen wrote:

As resource trickle does not count as gatherer, it is out of ticket.

Dec 1 2020, 10:20 AM
mammadori added a comment to D3155: Show Gatherers next to resource icons.
In D3155#139549, @Angen wrote:

Now units returning resources and going back do not count while walking.

Mh, true, I didn't consider that. I think we'll want to count those, but it will impose adding new calls in RETURNRESOURCE.

Dec 1 2020, 10:15 AM

Nov 30 2020

mammadori updated the summary of D3155: Show Gatherers next to resource icons.
Nov 30 2020, 3:47 PM
mammadori updated the summary of D3155: Show Gatherers next to resource icons.
Nov 30 2020, 3:44 PM
mammadori added a comment to D3155: Show Gatherers next to resource icons.
In D3155#139456, @Stan wrote:

It doesn't take ResourceTrickle into account though, not sure that's intended.

Nov 30 2020, 3:37 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Simplyfied, removed sets of gatherers, tied the counters to resourceSupply. Still not work on death of the unit, and really fast switching since resourcesupply handling, left debug code in to try to work this out.

Nov 30 2020, 1:33 PM

Nov 28 2020

mammadori added a comment to D3155: Show Gatherers next to resource icons.

There is a meta question which is "should we show gatherers or the sum of gather rates?" I'd probably prefer the latter.

Nov 28 2020, 8:32 PM
mammadori updated the summary of D3155: Show Gatherers next to resource icons.
Nov 28 2020, 5:14 PM
mammadori updated the diff for D3155: Show Gatherers next to resource icons.

Still missing moving the code from Player, but fixes some comments, it shows total gatherers under population icon too, which could be useful. Still not clear how to handle properly deaths, this patch should also handle replies better, although not ideal.

Nov 28 2020, 4:59 PM
mammadori added a comment to D3155: Show Gatherers next to resource icons.

(still suggesting moving all those to resourceGatherer)

Nov 28 2020, 11:00 AM

Nov 27 2020

mammadori updated the diff for D3155: Show Gatherers next to resource icons.

The UI works nicely now, the replay part needs some advice, not yet moved off "Player".

Nov 27 2020, 8:05 PM
mammadori updated the test plan for D3155: Show Gatherers next to resource icons.
Nov 27 2020, 5:58 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Nov 27 2020, 5:26 PM
mammadori added inline comments to D3155: Show Gatherers next to resource icons.
Nov 27 2020, 4:57 PM
mammadori updated the summary of D3155: Show Gatherers next to resource icons.
Nov 27 2020, 4:29 PM
mammadori requested review of D3155: Show Gatherers next to resource icons.
Nov 27 2020, 4:28 PM

Nov 23 2020

mammadori added inline comments to D3119: [WIP] Add a with-system-cxxtest.
Nov 23 2020, 10:07 PM