Fix crash in dynamic subscriptions when components unsubscribe during deletion.
Discussed with Philip.
Reviewed by fatherbushido
Differential Revision: https://code.wildfiregames.com/D264
Description
Description
Details
Details
- Committed
wraitii Apr 17 2017, 10:00 AM - Differential Revision
- D264: Fix crash in dynamic subscriptions when components unsubscribe during deletion.
- Parents
- rP19423: Add a test to the component manager to show a crash in dynamic subscriptions…
- Branches
- Unknown
- Tags
- Build Status
Buildable 1155 Build 1820: Trigger Windows Autobuild Build 1819: Post-Commit Build Jenkins
Event Timeline
Comment Actions
Patch
Revision 19425
Not sure why, couldn't reproduce with the visual replay, but got an error when hosting svn game:
ComponentManagerSerialization.cpp(186): Assertion failed: "m_DestructionQueue.empty()" Assertion failed: "m_DestructionQueue.empty()" Location: ComponentManagerSerialization.cpp:186 (SerializeState)
Replay
Patch
Revision 19425
Don't have a stack nor mainlog.html unfortunately, can't reproduce it when hosting a different game or visually replaying the thing.
Perhaps it can be reproduced by spawning and deleting some entities every turn. Perhaps it will reappear some time, perhaps it was a false alert, dunno