HomeWildfire Games

Botswanan Haven random map.
AuditedrP19548

Description

Botswanan Haven random map.

Differential Revision: https://code.wildfiregames.com/D362
Patch By: Hannibal_Baraq

Details

Auditors
Itms
Committed
elexisMay 9 2017, 10:09 PM
Differential Revision
D362: New map - Botswanan Haven
Parents
rP19547: petra: adapt garrisoning to the attackers
Branches
Unknown
Tags
Unknown
Build Status
Buildable 1597
Build 2519: Post-Commit BuildJenkins

Event Timeline

I've noticed on this map that sometimes trees spawn very close to each other and clip sharply, kind of like what happens sometimes on the "Kerala" random map.

I've noticed on this map that sometimes trees spawn very close to each other and clip sharply, kind of like what happens sometimes on the "Kerala" random map.

Couldn't reproduce trees being that close, got the first line of a replay file of that map?
If it's the 0 in [new SimpleObject(treeType, 1, 3, 0, 3)], then this should occur in more than those 2 maps

Itms raised a concern with this commit.May 27 2017, 2:56 PM
Itms added a subscriber: Itms.

A translator noticed a typo in the map name (I thought it was on purpose, but reading the comments in D362 they are right): it should be Heaven, not Haven, if you want a synonym for Paradise.

This commit now has outstanding concerns.May 27 2017, 2:56 PM
elexis requested verification of this commit.May 27 2017, 3:12 PM
In rP19548#21397, @Itms wrote:

A translator noticed a typo in the map name (I thought it was on purpose, but reading the comments in D362 they are right): it should be Heaven, not Haven, if you want a synonym for Paradise.

Heaven is not what is intended.
(At least from my understanding), it's more in the sense of a nice place of refuge, sanctuary. Like "tax haven" without the tax.

https://en.wiktionary.org/wiki/haven#Synonyms

refuge
sanctuary
zoar

Botswanan Heaven sounds a bit too idyllic

(Do we actually need to raise a concern on the commit for string issues if we have an existing report on transifex?)

This commit now requires verification by auditors.May 27 2017, 3:12 PM
Itms accepted this commit.May 27 2017, 5:38 PM

Like "tax haven" without the tax.

What's the point then ๐Ÿ˜œ

(Do we actually need to raise a concern on the commit for string issues if we have an existing report on transifex?)

No, I just thought, when reading "Haven/Paradise" in D362, that a mistake had been made, so that warranted an Issue. If that's on purpose, perfect.

All concerns with this commit have now been addressed.May 27 2017, 5:38 PM
In rP19548#21407, @Itms wrote:

Like "tax haven" without the tax.

What's the point then ๐Ÿ˜œ

(Do we actually need to raise a concern on the commit for string issues if we have an existing report on transifex?)

No, I just thought, when reading "Haven/Paradise" in D362, that a mistake had been made, so that warranted an Issue. If that's on purpose, perfect.

Oh, then I had a misconception about this being some refuge all along. I'd still find heaven a bit corny In case we rename, "Botswana(n) Paradise" might be nicer. Hannibal is N/A for the next months unfortunately.

Itms added a comment.May 27 2017, 6:05 PM

Oh, then I had a misconception about this being some refuge all along. I'd still find heaven a bit corny In case we rename, "Botswana(n) Paradise" might be nicer. Hannibal is N/A for the next months unfortunately.

I was just kidding, it is a kind of refuge indeed... But saving taxes is cool. No problem with waiting for Hannibal (I feel like a fat and bored Roman senator right now).