HomeWildfire Games

Add scrollbars to all tabs in Atlas.
Concern RaisedrP20058

Description

Add scrollbars to all tabs in Atlas.

Reviewed By: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D793

Details

Auditors
temple
Committed
bbAug 27 2017, 8:47 PM
Reviewer
vladislavbelov
Differential Revision
D793: Add scrollbars to all atlas tabs
Parents
rP20057: remove an unwanted change from last commit
Branches
Unknown
Tags
Unknown

Event Timeline

elexis raised a concern with this commit.Aug 30 2017, 11:55 PM
elexis added a subscriber: elexis.

Not fully sure if it's this revision:
When I start atlas, the "R" button near the random seed is invisible.
The arrows on the right side of the dropdown field are hidden.
When resizing the frame, it seems to clip to the random seed input field.

wx-config --version
3.0.2

ubuntu 16.04

This commit now has outstanding concerns.Aug 30 2017, 11:55 PM
elexis removed an auditor: elexis.Oct 16 2017, 3:46 PM

Fixed by rP20305, thanks! (Didn't review the rest of the code)

This commit no longer requires audit.Oct 16 2017, 3:46 PM
temple added a subscriber: temple.Oct 24 2017, 11:30 PM

There's a problem with the scrollbars in the object and cinema sidebars (on linux at least). Pictures here: https://imgur.com/a/Ctul1

temple raised a concern with this commit.Nov 1 2017, 2:16 AM

(Raising a concern just so it's not forgotten. It's not urgent.)

This commit now has outstanding concerns.Nov 1 2017, 2:16 AM

Seems this is fixed? I found no oddities on Linux and the image is gone.