HomeWildfire Games

Remove files which would break copyright

Description

Remove files which would break copyright
Add the links and the license to the other files and name the authors.
Thanks leper for the heads up.

Event Timeline

Any clue why the license file shows up as a binary file?

Thanks.

Stan added a comment.Nov 21 2017, 10:00 AM

Well apparently, even by setting the property (mime:type plain/text), Phabricator doesn't recognize it as at a text file https://stackoverflow.com/questions/2634043/svn-diff-file-marked-as-binary-type

In rP20489#25038, @Stan wrote:

Well apparently, even by setting the property (mime:type plain/text), Phabricator doesn't recognize it as at a text file https://stackoverflow.com/questions/2634043/svn-diff-file-marked-as-binary-type

Because the ñs in there are in some codepage and not in utf8. The file uses the wrong text encoding and according to https://secure.phabricator.com/book/phabricator/article/utf8/ that is most likely causing this.

leper added a subscriber: Itms.Nov 21 2017, 5:41 PM

Uhm, if that also wasn't the issue... @Itms Phabricator is stupid, trac works though.

Thanks for trying :-)

Itms added a comment.Nov 21 2017, 6:27 PM

Uhm, if that also wasn't the issue... @Itms Phabricator is stupid, trac works though.

Thanks for trying :-)

Is there anything we can do except making sure to use utf8? Since upstream documents that everything should be utf8 it's unlikely there is an easy patch to this problem.

Is there anything we can do except making sure to use utf8? Since upstream documents that everything should be utf8 it's unlikely there is an easy patch to this problem.

Well, unless you see something that makes rP20493 not be utf8, then I'm not sure if that is everything that is needed.

Itms added a comment.Nov 21 2017, 8:56 PM

Well, unless you see something that makes rP20493 not be utf8, then I'm not sure if that is everything that is needed.

It looks like it is considered binary because it was binary before the commit, no? For instance right now when browsing in Diffusion it is properly blame'd whereas looking at its history shows it as binary. I feel like if one commits a new change to it the commit will properly display the change, can't be sure though.